685905 - Add a ReplaceElementAt to nsTArray

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Mounir Lamouri (:mounir)]

It's already pretty annoying that nsTArray and nsCOMArray do not have the same method signatures but ReplaceElementsAt when we have to replace one element is quite frustrating...

Comment 1

[Atul Aggarwal]

Attachment: Patch v1

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 559664 [details] [diff] [review]
Patch v1

Review of attachment 559664 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the second version removed.

::: xpcom/glue/nsTArray.h
@@ +698,5 @@
> +  // A variation on the ReplaceElementsAt method defined above.
> +  template<class Item>
> +  elem_type *ReplaceElementAt(index_type index, const Item* item) {
> +    return ReplaceElementsAt(index, 1, item, 1);
> +  }

I'd rather not have this second signature. Just seems like a source of confusion since people can both pass a pointer to a object, or the object itself.

So just keep the reference version and make people use a deref operator if all they have is a pointer.

Comment 3

[Atul Aggarwal]

Attachment: Removed the second function as suggested by patch

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 560681 [details] [diff] [review]
Removed the second function as suggested by patch

For the record, if someone says "r=me with changes X", you don't really need to re-ask for review. Unless you disagree with the suggested changes or otherwise can't make them.

Comment 5

[Atul Aggarwal]

Thanks a lot Jonas. I didn't knew that. I am still learning the procedures.

Comment 6

[Ed Morley [:emorley]]

Doesn't apply to inbound, please update to tip and reattach. Thanks :-)

Comment 7

[Atul Aggarwal]

Attachment: Patch on tip.

Comment 8

[Dão Gottwald [:dao]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/182d4c0c1164

Comment 9

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/182d4c0c1164