685979 - string property name rule.showUnmatchedLink incorrect in styleinspector.properties

Status: RESOLVED WONTFIX

(DevTools :: General, defect)

Description

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment from bug 683672:

> -rule.showUnmatchedLink=One unmatched rule...;#1 unmatched rules...
> +rule.showUnmatchedLink=1 unmatched selector…;#1 unmatched selectors…
> 
> The property name should be changed when the meaning changes. Since selector
> != rule, this one here should be renamed, too.
>

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: rule.showUnmatchedLink rename patch 1

Comment 2

[Mihai Sucan [:msucan]]

Thanks for your quick response, Mike!

Comment 3

[Mihai Sucan [:msucan]]

Comment on attachment 559542 [details] [diff] [review]
rule.showUnmatchedLink rename patch 1

># HG changeset patch
># Parent 43f1efa4b17d442d0cd3c3867ed452431828f9e3
># User Michael Ratcliffe <[e-mail]>
># Date 1315596539 -3600
>
>Bug 685979 - string property name rule.showUnmatchedLink incorrect in styleinspector.properties
>
>diff --git a/browser/devtools/styleinspector/CssHtmlTree.jsm b/browser/devtools/styleinspector/CssHtmlTree.jsm
>--- a/browser/devtools/styleinspector/CssHtmlTree.jsm
>+++ b/browser/devtools/styleinspector/CssHtmlTree.jsm
>@@ -423,17 +423,17 @@ PropertyView.prototype = {
>   },
> 
>   /**
>    * The UI has a link to allow the user to display unmatched selectors.
>    * This provides localized link text.
>    */
>   get showUnmatchedLinkText()
>   {
>-    let smur = CssHtmlTree.l10n("rule.showUnmatchedLink");
>+    let smur = CssHtmlTree.l10n("selector.showUnmatchedLink");
>     let unmatchedSelectorCount = this.propertyInfo.unmatchedSelectors.length;
>     let plural = PluralForm.get(unmatchedSelectorCount, smur);
>     return plural.replace("#1", unmatchedSelectorCount);
>   },
> 
>   /**
>    * The action when a user clicks the 'show unmatched' link.
>    */
>diff --git a/browser/locales/en-US/chrome/browser/styleinspector.properties b/browser/locales/en-US/chrome/browser/styleinspector.properties
>--- a/browser/locales/en-US/chrome/browser/styleinspector.properties
>+++ b/browser/locales/en-US/chrome/browser/styleinspector.properties
>@@ -27,22 +27,22 @@ rule.status.UNMATCHED=Unmatched
> 
> # LOCALIZATION NOTE (rule.sourceElement, rule.sourceInline): For each
> # style property the panel shows the rules which hold that specific property.
> # For every rule, the rule source is also displayed: a rule can come from a
> # file, from the same page (inline), or from the element itself (element).
> rule.sourceInline=inline
> rule.sourceElement=element
> 
>-# LOCALIZATION NOTE (rule.showUnmatchedLink): For each style
>+# LOCALIZATION NOTE (selector.showUnmatchedLink): For each style
> # property the panel shows the number of selectors which do not match the
> # currently selected element, counted from all stylesheets in the web page
> # inspected.
> # See: http://developer.mozilla.org/en/docs/Localization_and_Plurals
>-rule.showUnmatchedLink=1 unmatched selectorâ¦;#1 unmatched selectorsâ¦
>+selector.showUnmatchedLink=1 unmatched selectorâ¦;#1 unmatched selectorsâ¦
> 
> # LOCALIZATION NOTE (group): Style properties are displayed in categories and
> # these are the category names.
> group.Text_Fonts_and_Color=Text, Fonts & Color
> group.Background=Background
> group.Dimensions=Dimensions
> group.Positioning_and_Page_Flow=Positioning and Page Flow
> group.Borders=Borders

Comment 4

[Mihai Sucan [:msucan]]

Patch looks fine for me. Hopefully it's fine for l10n as well.

Comment 5

[Marek Stępień [:marcoos, inactive]]

It looks ok to me.

Comment 6

[Axel Hecht [:Pike]]

Comment on attachment 559542 [details] [diff] [review]
rule.showUnmatchedLink rename patch 1

yep, feedback+, thanks.

Comment 7

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

I have noticed that we remove this string in bug 674856 (ready to land) ... with this in mind is it okay if we close this bug?

Comment 8

[Mihai Sucan [:msucan]]

This patch doesn't need to land. The string is going to be removed by the patch from bug 674856, which will land ASAP.

Thanks Mike!