68631 - lack of arch-specific compiler flags in security/coreconf/Linux.mk

Status: VERIFIED INVALID

(Core Graveyard :: Security: UI, defect, P3)

Description

[John "AntiTuX" Dee]

I did the official build of mozilla 0.7 for linux-sparc64, and came across a
peculiar problem.

Originally, there were no arch-specific compile flags for PSM in
linux-sparc/sparc64, so when trying to make the official build, PSM wouldn't
compile. I submitted a patch, which is still on Duke34.mcom.com, and was emailed
back told that the problem was already solved.

I think that the that was went about solving it was flawed.

My reasoning behind this is that instead of adding arch-specific compile flags,
you added generic ones, causing PSM to run at approximately 25% slower speed.
I'm putting another patch on http://Duke34.mcom.com to show how I believe that
the original patch SHOULD have been done.

This might also solve you issues with compiles of PSM, if you're still looking
at those.

The new patch is located at
http://duke34.mcom.com/architecture-compile-optimizations-Linux.mk.PATCH

If you have any problems/comments/concerns, please contact me.
Thanks

Comment 1

[John "AntiTuX" Dee]

Attachment: arch-specific compile patches

Comment 2

[Keyser Sose]

Marking NEW to get someone to look and review the patch.

Comment 3

[John "AntiTuX" Dee]

I bass-ackwarded the patch,
the fixed one is on http://bofh1.mcom.com

Comment 4

[John Unruh]

Reporter, is this still a problem now that PSM 2.0 is integrated into the 
nightly builds?

Comment 5

[Bob Lord]

-> 2.0
-> P3

Comment 6

[Stephane Saux]

version 2.0
target 2.1

Comment 7

[Stephane Saux]

Moving all P3 and P4 bugs targetted to 2.1 to future.

Comment 8

[Stephane Saux]

removing nsenterprise keyword from PSM bugs with target milestone of future.

Comment 9

[John Unruh]

Mass assigning QA to ckritzer.

Comment 10

[John Unruh]

Marking invalid, since there has been no comment from the reporter in 6 months. 
Reporter, please reopen if there is still a problem.

Comment 11

[John "AntiTuX" Dee]

nah, that's cool.

Comment 12

[John Unruh]

Verified.