686317 - format string/argument list mismatches in ARMAssembler.h

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jonathan Kew [:jfkthame]]

Attachment: patch, correct format-string mismatches in ARMAssembler.h

When building for Android, I'm seeing a number of warnings about mismatches between printf-style format strings and the supplied arguments:

/home/jonathan/mozdev/mc-android/js/src/assembler/assembler/ARMAssembler.h: In member function 'void JSC::ARMAssembler::mem_imm_off(bool, bool, int, bool, int, int, JSC::ARMWord, JSC::ARMAssembler::Condition)':
/home/jonathan/mozdev/mc-android/js/src/assembler/assembler/ARMAssembler.h:591: warning: format '%u' expects type 'unsigned int', but argument 9 has type 'const char*'
/home/jonathan/mozdev/mc-android/js/src/assembler/assembler/ARMAssembler.h:591: warning: too many arguments for format
/home/jonathan/mozdev/mc-android/js/src/assembler/assembler/ARMAssembler.h: In member function 'void JSC::ARMAssembler::mem_reg_off(bool, bool, int, bool, int, int, int, JSC::ARMAssembler::Condition)':
/home/jonathan/mozdev/mc-android/js/src/assembler/assembler/ARMAssembler.h:630: warning: too many arguments for format
/home/jonathan/mozdev/mc-android/js/src/assembler/assembler/ARMAssembler.h: In static member function 'static void JSC::ARMAssembler::repatchInt32(void*, int32_t)':
/home/jonathan/mozdev/mc-android/js/src/assembler/assembler/ARMAssembler.h:1056: warning: format '%p' expects type 'void*', but argument 4 has type 'int32_t'
/home/jonathan/mozdev/mc-android/js/src/assembler/assembler/ARMAssembler.h: In member function 'void JSC::ARMAssembler::fcpyd_r(int, int, JSC::ARMAssembler::Condition)':
/home/jonathan/mozdev/mc-android/js/src/assembler/assembler/ARMAssembler.h:1610: warning: too few arguments for format
/home/jonathan/mozdev/mc-android/js/src/assembler/assembler/ARMAssembler.h: In member function 'void JSC::ARMAssembler::fabsd_r(int, int, JSC::ARMAssembler::Condition)':
/home/jonathan/mozdev/mc-android/js/src/assembler/assembler/ARMAssembler.h:1653: warning: too few arguments for format

The attached patch is my guess at how these should be resolved, from inspection of the lines in question; however, I don't speak ARM assembler, so it would be good to have someone check that they make sense.

Comment 1

[Jonathan Kew [:jfkthame]]

Pushed to mozilla-inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1e7cfb65f195

Comment 2

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/1e7cfb65f195