686371 - Fix pixman compilation for iOS

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[(not currently active) Ted Mielczarek]

Currently Apple's assembler can't handle the ARM assembly pixman has. I have a patch that makes us use the C fallbacks, but that seems like a crummy way to go. I'm sure the actual assembly code works fine, it would just need to be massaged to make Apple as happy.

Comment 1

[(not currently active) Ted Mielczarek]

Attachment: Use C fallback on iOS

Here's the patch to use the C fallback. It's not great, but it's the easiest thing to start with.

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 559906 [details] [diff] [review]
Use C fallback on iOS

Jeff and I talked about this yesterday, this is the easiest solution for now. Once clang's ARM/iOS assembler is in a better state, we'll revisit this.

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 559906 [details] [diff] [review]
Use C fallback on iOS

Please add a comment about why, so that it's easy to take this out in the future.

Comment 4

[(not currently active) Ted Mielczarek]

http://hg.mozilla.org/projects/build-system/rev/7641937ce773

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/mozilla-central/rev/7641937ce773