Closed
Bug 686449
Opened 13 years ago
Closed 13 years ago
Make ProcessingInstruction inherit from CharacterData
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: annevk, Assigned: smaug)
References
Details
Attachments
(1 file)
8.32 KB,
patch
|
sicking
:
review+
|
Details | Diff | Splinter Review |
We changed DOM4 so that ProcessingInstruction is much more like Text and Comment.
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → Olli.Pettay
Assignee | ||
Comment 1•13 years ago
|
||
uploaded to try
Assignee | ||
Updated•13 years ago
|
Attachment #560267 -
Flags: review?(jonas)
Attachment #560267 -
Flags: review?(jonas) → review+
Assignee | ||
Comment 2•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f7cbb2d9c61d
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment 3•11 years ago
|
||
This seems to have regressed updating the contents of a PI and having that restyle the document - but re-inserting the PI after changing its contents offers a workaround. Is this expected behaviour (maybe the API we're supposed to use changed?), or should I file a bug to fix this in core? See bug 888672 for more details and easy STR.
Flags: needinfo?(bugs)
Comment 4•11 years ago
|
||
Please file a bug. It seems that it might be caused by pi->SetData now calling nsGenericDOMDataNode::SetData -> SetTextInternal directly rather than SetNodeValue -> SetNodeValueInternal which XMLStylesheetProcessingInstruction overrides.
Flags: needinfo?(bugs)
Assignee | ||
Comment 5•11 years ago
|
||
Yes, new bug please.
Updated•11 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•