6865 - {css1} Inline box model is not considering block-level parent's line-height

Status: VERIFIED FIXED

(Core :: Layout, defect, P2)

Description

[Hixie (not reading bugmail)]

You fail test 2 on this EvilTest:
   http://www.bath.ac.uk/%7Epy8ieh/internet/eviltests/lineheight2.html

From http://www.w3.org/TR/REC-CSS2/visudet.html#propdef-line-height :
   If [line-height] is set on a block-level element whose content is
   composed of inline-level elements, it specifies the minimal height of
   each generated inline box.

See also:
   http://lists.w3.org/Archives/Public/www-style/1999Jan/0037.html

Comment 1

[Hixie (not reading bugmail)]

*** Bug 4304 has been marked as a duplicate of this bug. ***

Comment 2

[Hixie (not reading bugmail)]

*** Bug 7097 has been marked as a duplicate of this bug. ***

Comment 3

[Hixie (not reading bugmail)]

See also bug 7097's test page:
   http://www.netppl.fi/%7esairwas/tests/image-links-vspacing/

AFAICT, the images should have gaps between them on both lines.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

As I've said before, I think that statement in CSS2 should have said line box
rather than inline box.  However, I don't think there's been official word yet.

Comment 5

[Hixie (not reading bugmail)]

As mentioned in bug 5821, fixing this should be relatively easy: you just have to
insert an anonymous inline element around all inline content in a block, and
then set its line-height to 'inherit'. For example, the following:

   <div>
      <span> abc </span>
      <span> def </span>
   </div>

...would internally become

   <div>
      <anonymous-inline style="line-height: inherit">
         <span> abc </span>
         <span> def </span>
      </anonymous-inline>
   </div>

I believe that is all that is needed; David may be able to confirm or deny.

[Moving to M11 like 5821, as this should be fixed before 5821...]

Comment 6

[kipp]

Turns out to have been a bug in line-height inheritance which is now fixed.

Comment 7

[Christine Hoffman]

Using 9/28 Apprunner and the Evil Test provided, verified bug fixed. The
examples in 2. display identically to the two cases in 1.

Comment 8

[Hixie (not reading bugmail)]

Migrating from {css1} to css1 keyword. The {css1}, {css2}, {css3} and {css-moz}
radars should now be considered deprecated in favour of keywords.
Sorry for the spam...