Closed
Bug 686775
Opened 13 years ago
Closed 13 years ago
External API version of StripWhitespace fails to strip \b
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla11
People
(Reporter: neil, Assigned: atulagrwl)
Details
(Whiteboard: [good first bug])
Attachments
(1 file)
|
1.57 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
The internal API version of StripWhitespace strips kWhitespace which is defined to be "\b\t\r\n "; however the external API version of StripWhitespace uses " \t\n\r" and " \t\r\n" thus overlooking the "\b".
|
||
Comment 1•13 years ago
|
||
What does it mean to strip \b? Isn't that a zero-width match?
|
Reporter | |
Comment 2•13 years ago
|
||
You're thinking regexp. This is a string literal, so it's backspace.
|
Assignee | |
Comment 3•13 years ago
|
||
Assignee: nobody → atulagrwl
Attachment #573139 -
Flags: review?(benjamin)
|
||
Updated•13 years ago
|
Attachment #573139 -
Flags: review?(benjamin) → review+
|
|
Assignee | |
Updated•13 years ago
|
Keywords: helpwanted → checkin-needed
|
||
Comment 4•13 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/4dc32cede297
Keywords: checkin-needed
Target Milestone: --- → mozilla11
|
||
Comment 5•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4dc32cede297
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•3 years ago
|
Component: String → XPCOM
You need to log in
before you can comment on or make changes to this bug.
Description
•