Closed
Bug 686778
Opened 13 years ago
Closed 13 years ago
Web console: Move close button to the left on Mac
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 9
People
(Reporter: jaws, Assigned: jaws)
References
Details
(Whiteboard: [fixed-in-fx-team])
Attachments
(2 files, 1 obsolete file)
|
48.36 KB,
image/png
|
Details | |
|
1.17 KB,
patch
|
jaws
:
review+
|
Details | Diff | Splinter Review |
pre-patch screenshot
Bug 684561 moved the close button to the right on Windows but accidentally moved the close button to the right on Mac as well. Also some toolbarbutton margins that were increased on winstripe are also needed on gnomestripe.
Attachment #560252 -
Flags: review?(dcamp)
|
Assignee | |
Updated•13 years ago
|
Assignee: nobody → jwein
Status: NEW → ASSIGNED
|
||
Updated•13 years ago
|
Attachment #560252 -
Flags: review?(dcamp)
Attachment #560252 -
Flags: review?(dao)
Attachment #560252 -
Flags: review+
|
||
Comment 1•13 years ago
|
||
Here's what the buttons look like for me on Linux without this patch. This looks ok to me, I don't think more space around them is needed.
|
|
Assignee | |
Comment 2•13 years ago
|
||
Removed the style changes for gnomestripe since it wasn't too terrible looking on gnomestripe pre-patch. HUDService.jsm was r+ from dcamp whereas webconsole.css review was forwarded to dao. Therefore, I'll carry forward r+ from dcamp.
Attachment #560252 -
Attachment is obsolete: true
Attachment #560252 -
Flags: review?(dao)
Attachment #560825 -
Flags: review+
|
|
Assignee | |
Updated•13 years ago
|
Summary: Web console: Move close button to the left on Mac and carry over style changes from Windows to Linux → Web console: Move close button to the left on Mac
|
|
Assignee | |
Updated•13 years ago
|
Whiteboard: [fixed-in-fx-team]
|
||
Comment 3•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4866693ce45c
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 9
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•