686857 - Tab is closed when tapping near the "X" button

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Andreea Pod]

Mozilla /5.0 (Android;Linux armv7l;rv:9.0a1) Gecko/20110914 Firefox/9.0a1 Fennec/9.0a1
Device: HTC Desire Z (Android 2.3)

Steps to reproduce:
1. Open a few tabs
2. Go to tab panel
3. tap on a tab between the middle of the tab and the X button

Expected results:
nothing should happen if the tab is in focus, if not it should get in focus

Actual result:
the tab is closed, please see the video: http://www.screencast.com/users/AndreeaDiana/folders/Jing/media/5018c266-0b1b-42d9-90ce-199c3cb4dd53

Note: 
- this is happening only on Android 2.3
- I made the video using DeviceAnywhere because using the real device would not be so clear that the click is not performed on the "X" button.

Comment 1

[Aaron Train [:aaronmt]]

This is probably by design as they have a large 'hit' zone.

Comment 2

[Martijn Wargers (dead)]

This is far too easy to hit, currently. The 'hit' zone of the close button is for the phone UI at least, far too great, now. Tapping in the middle of the thumbnail even cause the tab to be closed.

Comment 3

[Lucas Rocha (:lucasr)]

Attachment: Make clickable area match close button boundaries

Comment 4

[Ed Morley [:emorley]]

Didn't apply cleanly, but fixed locally and pushed to inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1c97a4d89f91

Comment 5

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/1c97a4d89f91

Comment 6

[Aaron Train [:aaronmt]]

Mozilla/5.0 (Android; Linux armv7l; rv:9.0a1) Gecko/20110919 Firefox/9.0a1 Fennec/9.0a1