686876 - Move libraries at the top level in the apk

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Android, defect)

Description

[Mike Hommey [:glandium]]

I don't think there still are reasons to keep libraries under lib/ in the apk. And it would make my planned changes to the linker easier if they weren't.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Move libraries at the top level in the apk

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Hmm, I can't recall why we used lib/ in the first place. Vlad and BLassey might know. Mike, do you know why we did it?

Comment 3

[Mike Hommey [:glandium]]

Really none, apparently. The libs were all in lib/armeabi when we didn't have the custom linker. Then bug 588607 changed it so that only libmozutils is there, and other libs are in lib/. But I don't see a specific reason for their location to be lib/.

Comment 4

[Mike Hommey [:glandium]]

Attachment: Move libraries at the top level in the apk

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 561312 [details] [diff] [review]
Move libraries at the top level in the apk


>diff --git a/toolkit/mozapps/installer/packager.mk b/toolkit/mozapps/installer/packager.mk

>@@ -265,16 +265,30 @@ DIST_FILES = \

>   lib \

Is anything left in the lib folder?


Let's do it and see what shakes lose. Patch looks good.

Comment 6

[Mike Hommey [:glandium]]

(In reply to Mark Finkle (:mfinkle) from comment #5)
> Is anything left in the lib folder?

libmozutils.so, which is in lib/armeabi-v7a.

Comment 7

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/50115be8eaf0

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/50115be8eaf0