Closed
Bug 687166
Opened 13 years ago
Closed 13 years ago
GCC 4.6 build warning: "layout/xul/base/src/nsSplitterFrame.cpp:997: warning: variable 'current' set but not used [-Wunused-but-set-variable]"
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla10
People
(Reporter: froydnj, Assigned: froydnj)
References
(Blocks 1 open bug)
Details
(Whiteboard: [build_warning])
Attachments
(1 file, 2 obsolete files)
The `current' variable in nsSplitterFrameInner::SetPreferredSize is set but unused. Patch coming up.
Assignee | ||
Comment 1•13 years ago
|
||
Assignee: nobody → nfroyd
Attachment #560633 -
Flags: review?(Olli.Pettay)
Comment 2•13 years ago
|
||
Comment on attachment 560633 [details] [diff] [review] remove set-but-unused variable current Could you remove also //printf("current=%d, pref=%d", current/onePixel, pref/onePixel);
Attachment #560633 -
Flags: review?(Olli.Pettay) → review+
Updated•13 years ago
|
Blocks: buildwarning
Updated•13 years ago
|
Whiteboard: [build_warning]
Updated•13 years ago
|
Keywords: checkin-needed
Comment 3•13 years ago
|
||
Attachment #560633 -
Attachment is obsolete: true
Comment 4•13 years ago
|
||
(In reply to Atul Aggarwal from comment #3) I suppose you'd like to carry over review+.
Assignee | ||
Comment 5•13 years ago
|
||
Assignee | ||
Comment 6•13 years ago
|
||
Comment on attachment 565210 [details] [diff] [review] GCC 4.6 build warning: "layout/xul/base/src/nsSplitterFrame.cpp:997: warning: variable current set but not used [-Wunused-but-set-variable]". Rebased patch with smaug's requested change. Carrying over initial r+.
Attachment #565210 -
Flags: review+
Assignee | ||
Comment 7•13 years ago
|
||
Comment on attachment 564030 [details] [diff] [review] Rebase with the bool change Marking previous rebased patch as obsolete.
Attachment #564030 -
Attachment is obsolete: true
Assignee | ||
Comment 8•13 years ago
|
||
Comment on attachment 565210 [details] [diff] [review] GCC 4.6 build warning: "layout/xul/base/src/nsSplitterFrame.cpp:997: warning: variable current set but not used [-Wunused-but-set-variable]". Whoops, I'm not the reviewer here.
Comment 9•13 years ago
|
||
In my queue, which is heading to try first then inbound :-) https://tbpl.mozilla.org/?tree=Try&rev=a8fbb2a76633
Comment 10•13 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/d7b86824694a
Status: NEW → ASSIGNED
Flags: in-testsuite-
Target Milestone: --- → mozilla10
Version: unspecified → Trunk
Comment 11•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d7b86824694a
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•