687389 - MSVC 2010 warning C4005: '_WIN32_WINNT' : macro redefinition for various files under accessible/public/*

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Ed Morley [:emorley]]

MSVC 2010 using http://hg.mozilla.org/integration/mozilla-inbound/rev/f827e9173fea

{
ISimpleDOMDocument_i.c
c:\mozilla\repos\obj-inbound\accessible\public\msaa\../../../dist/include/mozilla-config.h(91) : warning C4005: '_WIN32_WINNT' : macro redefinition
        command-line arguments :  see previous definition of '_WIN32_WINNT'
ISimpleDOMNode_i.c
c:\mozilla\repos\obj-inbound\accessible\public\msaa\../../../dist/include/mozilla-config.h(91) : warning C4005: '_WIN32_WINNT' : macro redefinition
        command-line arguments :  see previous definition of '_WIN32_WINNT'
...plus more under accessible/public/msaa/
}

{
Accessible2_p.c
c:\mozilla\repos\obj-inbound\accessible\public\ia2\../../../dist/include/mozilla-config.h(91) : warning C4005: '_WIN32_WINNT' : macro redefinition
        command-line arguments :  see previous definition of '_WIN32_WINNT'
AccessibleAction_p.c
c:\mozilla\repos\obj-inbound\accessible\public\ia2\../../../dist/include/mozilla-config.h(91) : warning C4005: '_WIN32_WINNT' : macro redefinition
        command-line arguments :  see previous definition of '_WIN32_WINNT'
...plus ~20 more under accessible/public/ia2/
}

Caused by the |DEFINES += -DREGISTER_PROXY_DLL -D_WIN32_WINNT=0x400| lines here:
http://mxr.mozilla.org/mozilla-central/search?string=_WIN32_WINNT&find=accessible%2Fpublic%2F

Comment 1

[Ed Morley [:emorley]]

Attachment: Patch v1

Removes the _WIN32_WINNT defines in: accessible/public/msaa/Makefile.in and accessible/public/ia2/Makefile.in , which existed at least as far back as CVS days, but seem redundant given the defines that end up in mozilla-config.h.

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 560834 [details] [diff] [review]
Patch v1

I'd prefer that an a11y peer review this.

Comment 3

[alexander :surkov (:asurkov)]

This code is 8 years old (bug 199518) and I didn't find a reason why it was introduced. This define isn't used in sources explicitly but I'm not sure if it can affect on dll creation or registration. What possible value are available and how they are used, do Windows header files rely on it, any hint?

Comment 4

[Ed Morley [:emorley]]

khuey or ted might be able to answer that, adding to CC :-)

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://msdn.microsoft.com/en-us/library/aa383745%28v=vs.85%29.aspx#setting_winver_or__win32_winnt

It controls what definitions are made available in the Windows headers.

Comment 6

[alexander :surkov (:asurkov)]

Comment on attachment 560834 [details] [diff] [review]
Patch v1

r=me

Comment 7

[Ed Morley [:emorley]]

https://tbpl.mozilla.org/?tree=Try&usebuildbot=1&rev=39b4ffb18fd5

https://hg.mozilla.org/integration/mozilla-inbound/rev/0c47234a4021

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/0c47234a4021