687689 - Reduce the number of returned search results to from 500 to 250

Status: VERIFIED FIXED

(Socorro :: General, task)

Description

[Matt Brandt [:mbrandt]]

Would it be possible to tune down the number of results before pagination from 500 to 250? We believe we're seeing inconsistent failures in some of our automated tests due to an out-of-memory error that is occurring in our testing env.

Example query:

https://crash-stats.mozilla.com/report/list?product=Fennec&query_search=signature&query_type=contains&reason_type=contains&date=09%2F19%2F2011%2014%3A41%3A53&range_value=1&range_unit=weeks&hang_type=any&process_type=any&do_query=1&signature=inflate_fast_copy_neon

Comment 1

[Lonnen :lonnen]

Pull request from stephenD: https://github.com/stephendonner/socorro/commit/f490e6cc96faf2b262a7e51da0644cc04e9e68f9 

r+

merged as https://github.com/mozilla/socorro/commit/f080a840486b4a6583582ab01919a468040a6b38

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

This can currently be checked out on https://crash-stats-dev.allizom.org/report/list?range_value=28&range_unit=days&date=2011-09-22&signature=PInvokeCalliWorker&version=Firefox%3A6.0.2

Comment 3

[Matt Brandt [:mbrandt]]

QA verified ... many thx stephend :-)

https://crash-stats-dev.allizom.org/report/list?range_value=28&range_unit=days&date=2011-09-22&signature=PInvokeCalliWorker&version=Firefox%3A6.0.2

Comment 4

[Matt Brandt [:mbrandt]]

Urg ... sorry. I mis-verified this bug. It look like the results set is still returning 500 per page before pagination occurs.

ttps://crash-stats.mozilla.com/report/list?product=Fennec&query_search=signature&query_type=contains&reason_type=contains&date=09%2F19%2F2011%2014%3A41%3A53&range_value=1&range_unit=weeks&hang_type=any&process_type=any&do_query=1&signature=inflate_fast_copy_neon

Comment 5

[Robert Helmer [:rhelmer]]

This actually needs to be set in the puppet config (we don't have an easy override system for the PHP app like we do for the python apps).

I just checked this in, will close the bug when we get it pushed:

Committed revision 22037.

The value on stage was 25 for some reason, it's now:

$config['number_report_list'] = 25;

Let's just double-check it looks ok on stage after this bug is resolved and we can do the same on prod.

Comment 6

[Matt Brandt [:mbrandt]]

Thanks rhelmer ... I had gotten a note from our team in Romania that the counts were off. :-)

Comment 7

[Robert Helmer [:rhelmer]]

Pushed to crash-stats.allizom.org

Comment 8

[Matt Brandt [:mbrandt]]

QA verified with the help of one of brandonsavage's elegant solution. Cheers.