Closed
Bug 687848
Opened 13 years ago
Closed 13 years ago
crash in TB when import email from outlook 2007 due to OOM
Categories
(MailNews Core :: Import, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 11.0
People
(Reporter: colin, Assigned: mikekaganski)
References
()
Details
(Keywords: crash, testcase-wanted, Whiteboard: [GS][need message that causes the crash])
Crash Data
Attachments
(2 files, 1 obsolete file)
108.50 KB,
text/plain
|
Details | |
1.06 KB,
patch
|
Bienvenu
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 5.1) AppleWebKit/534.24 (KHTML, like Gecko) Chrome/11.0.696.65 Safari/534.24 Steps to reproduce: tried again Actual results: its crashed again Expected results: should have worked
Comment 1•13 years ago
|
||
Can you give us the crash ID ? (see http://support.mozillamessaging.com/bg/kb/Mozilla-Crash-Reporter)
Updated•13 years ago
|
Severity: normal → critical
Updated•13 years ago
|
Status: UNCONFIRMED → NEW
Crash Signature: https://crash-stats.mozilla.com/report/index/bp-9e5c74b7-a016-467b-9e87-acdb92110920
Ever confirmed: true
Whiteboard: [GS]
Updated•13 years ago
|
Crash Signature: https://crash-stats.mozilla.com/report/index/bp-9e5c74b7-a016-467b-9e87-acdb92110920 → bp-9e5c74b7-a016-467b-9e87-acdb92110920
bp-5db16c86-a988-41a9-b670-b73d82110920
1318c415-194c-4ef1-a5e5-008e22110920
Comment 2•13 years ago
|
||
This is OOM.
Crash Signature: bp-9e5c74b7-a016-467b-9e87-acdb92110920
bp-5db16c86-a988-41a9-b670-b73d82110920
1318c415-194c-4ef1-a5e5-008e22110920 → [@ mozalloc_abort(char const* const) | mozalloc_handle_oom() | moz_xmalloc | nsLocalFile::Clone(nsIFile**)]
[@ mozalloc_abort(char const* const) | mozalloc_handle_oom() | moz_xmalloc | NS_NewLocalFile_P ]
[@ mozalloc_abort(char const* const) | mozalloc…
Updated•13 years ago
|
Crash Signature: [@ mozalloc_abort(char const* const) | mozalloc_handle_oom() | moz_xmalloc | nsLocalFile::Clone(nsIFile**)]
[@ mozalloc_abort(char const* const) | mozalloc_handle_oom() | moz_xmalloc | NS_NewLocalFile_P ]
[@ mozalloc_abort(char const* const) | → [@ mozalloc_abort(char const* const) | mozalloc_handle_oom() | moz_xmalloc | nsLocalFile::Clone(nsIFile**) ]
[@ mozalloc_abort(char const* const) | mozalloc_handle_oom() | moz_xmalloc | NS_NewLocalFile_P ]
[@ mozalloc_abort(char const* const) |
Summary: crash in TB when import email from outlook 2007 → crash in TB when import email from outlook 2007 due to OOM
Comment 3•13 years ago
|
||
bp-9e5c74b7-a016-467b-9e87-acdb92110920 0 mozalloc.dll mozalloc_abort memory/mozalloc/mozalloc_abort.cpp:78 1 mozalloc.dll mozalloc_handle_oom memory/mozalloc/mozalloc_oom.cpp:54 2 mozalloc.dll moz_xmalloc memory/mozalloc/mozalloc.cpp:102 3 xul.dll nsLocalFile::Clone xpcom/io/nsLocalFileWin.cpp:842 4 xul.dll nsDirectoryService::Get xpcom/io/nsDirectoryService.cpp:431 5 xul.dll nsPrefBranch::GetComplexValue modules/libpref/src/nsPrefBranch.cpp:310 6 xul.dll nsMsgIncomingServer::GetFileValue mailnews/base/util/nsMsgIncomingServer.cpp:474 7 xul.dll nsMsgIncomingServer::GetLocalPath mailnews/base/util/nsMsgIncomingServer.cpp:936 8 xul.dll nsMsgDBFolder::parseURI mailnews/base/util/nsMsgDBFolder.cpp:3194 9 xul.dll nsMsgDBFolder::GetFilePath mailnews/base/util/nsMsgDBFolder.cpp:4668 10 xul.dll nsMsgDBFolder::GetFolderCacheKey mailnews/base/util/nsMsgDBFolder.cpp:1282 11 xul.dll nsMsgDBFolder::ReadDBFolderInfo mailnews/base/util/nsMsgDBFolder.cpp:650 12 xul.dll nsMsgDBFolder::SetFlag mailnews/base/util/nsMsgDBFolder.cpp:4217 13 xul.dll nsMsgIdentity::setFolderPref mailnews/base/util/nsMsgIdentity.cpp:421 14 xul.dll nsMsgIdentity::getFolderPref mailnews/base/util/nsMsgIdentity.cpp:328 15 xul.dll nsMsgIdentity::GetFccFolder mailnews/base/util/nsMsgIdentity.cpp:190 16 xul.dll GetFolderURIFromUserPrefs mailnews/compose/src/nsMsgCompUtils.cpp:1994 17 xul.dll nsMsgComposeAndSend::InitCompositionFields mailnews/compose/src/nsMsgSend.cpp:2923 18 xul.dll nsMsgComposeAndSend::Init mailnews/compose/src/nsMsgSend.cpp:3405 19 xul.dll nsMsgComposeAndSend::CreateAndSendMessage mailnews/compose/src/nsMsgSend.cpp:4285
Assignee | ||
Comment 4•13 years ago
|
||
Note that the two crash reports: https://crash-stats.mozilla.com/report/index/1318c415-194c-4ef1-a5e5-008e22110920 and https://crash-stats.mozilla.com/report/index/9e5c74b7-a016-467b-9e87-acdb92110920 occur when importing from different sources: the first one is from Outlook Express, while the second is from Outlook. These may be the same problem in some core module, or two different bugs in the respective import modules. Anyway, it would be helpful fo get the message that causes the crash. (Personally I could try to asist in tracking this problem in Outlook.) Unfortunately, I cannot suggest any other method but to create a new folder in Outlook, that would be named alphabetically prior to the crashing one, and try to move there some messages until you find the problem mail. If you will succeed, then please save that mail as .MSG file, and attach it here. I think that some similar approach could be used to find the offending message in OE.
Comment 5•13 years ago
|
||
There are also people importing and crashing with mozalloc_abort(char const* const) | mozalloc_handle_oom() | moz_xmalloc with nsLocalFile::nsLocalFileConstructor or something similar in the stack, ref: bug 613439, bug 609039 for example bp-3b20798b-9945-4467-b723-7951a2110828 (allan) bp-ad9a2b4b-49f2-4514-957c-4c2092110905 bp-44a6f5f7-cf77-4f10-a401-4cb492110906 bp-c54ee284-a8fa-480e-9844-dde542110829
Crash Signature: mozalloc_handle_oom() | moz_xmalloc | nsOEScanBoxes::Find50MailBoxes(nsIFile*) ] → mozalloc_handle_oom() | moz_xmalloc | nsOEScanBoxes::Find50MailBoxes(nsIFile*) ]
[@ operator new(unsigned int) | nsOEScanBoxes::Find50MailBoxes(nsIFile*) ]
[@ nsOEScanBoxes::Scan50MailboxDir(nsIFile*) ]
Comment 6•13 years ago
|
||
another exemple on Thunderbird 7 and Win7: https://crash-stats.mozilla.com/report/index/d4d329df-242c-4f10-9ce8-262332111018 I don't know why its crash report is not linked to this bug report...
OS: Windows XP → All
Version: 6 → Trunk
Comment 7•13 years ago
|
||
*Note: this crash is #1 outlook issue in getsatisfaction* as far as I can tell (In reply to caméléon from comment #6) > another exemple on Thunderbird 7 and Win7: > https://crash-stats.mozilla.com/report/index/d4d329df-242c-4f10-9ce8- > 262332111018 > I don't know why its crash report is not linked to this bug report... This is Hugues' crash reported at http://getsatisfaction.com/mozilla_messaging/topics/crash_when_import_mail_from_outllok#reply_6925948 and has a different signature mozalloc_abort(char const* const) | mozalloc_handle_oom() | moz_xmalloc | nsLocalFile::nsLocalFileConstructor(nsISupports*, nsID const&, void**)
Component: Migration → Import
Keywords: testcase-wanted
Product: Thunderbird → MailNews Core
QA Contact: migration → import
Whiteboard: [GS] → [GS][need message that causes the crash]
I identified which message caused ThunderBird to crash during import of messages from Outlook. When I deleted this message, all imports went well.
Comment 9•13 years ago
|
||
Could you please attach the message as MS Outlook .MSG file (or a .ZIP containing the message file).
Assignee | ||
Comment 10•13 years ago
|
||
(In reply to Jorg K from comment #9) > Could you please attach the message as MS Outlook .MSG file (or a .ZIP > containing the message file). This appears to be a correct .MSG file, but its MIME type chosen improperly (text/plain). When downloaded using some descent download manager, it opens in Outlook correctly, and does cause crash. I am going to try to debug this shortly.
Assignee | ||
Comment 11•13 years ago
|
||
Hugues, thank you very much for your sample. I found the cause of this error. This patch should fix this.
Attachment #573094 -
Flags: review?(dbienvenu)
Comment 12•13 years ago
|
||
I don't have access to Outlook 2007, and I didn't crash with Outlook 2010, after dragging the .msf file into Outlook. So I'm at a bit of a loss as to how to verify this fix. Any ideas? Also, you shouldn't just comment out the tmp file lines. They should simply be removed. Or, I think it might make more sense to simply null out tmp_file, after releasing it, i.e., (*tmp_file)->Release(); *tmp_file = 0; that would prevent the caller from being able to release it, I think.
Comment 13•13 years ago
|
||
sorry, that should read "dragging the .msg file into Outlook 2010" Perhaps a pst file from Outlook 2007 with the msg(s) would cause the crash w/ Outlook 2010?
Assignee | ||
Comment 14•13 years ago
|
||
I use Outlook 2010 now, and importing the message from it does cause the crash. (Well, I don't know why, but first time I tried, my TB didn't crash, too, but after restarting both Outlook and TB, the crash on my system is guaranteed.) I'll post updated patch when I'll be at development PC. I think that the second option is more correct and clear.
Comment 15•13 years ago
|
||
My 8.0 shipping build does crash in import, but my trunk debug build doesn't. I'll see if a trunk release build crashes...
Comment 16•13 years ago
|
||
Comment on attachment 573094 [details] [diff] [review] Fix improper unescape guard; fix double release of an interface minusing while a new patch addressing comments is prepared. The Check() change looks OK to me, even if I can't recreate the crash in a version I build...
Attachment #573094 -
Flags: review?(dbienvenu) → review-
Assignee | ||
Comment 17•13 years ago
|
||
Attachment #573094 -
Attachment is obsolete: true
Attachment #574000 -
Flags: review?(dbienvenu)
Comment 18•13 years ago
|
||
Comment on attachment 574000 [details] [diff] [review] Addressing David's comments thx, Mike.
Attachment #574000 -
Flags: review?(dbienvenu) → review+
Updated•13 years ago
|
Keywords: checkin-needed
Comment 19•13 years ago
|
||
Checked in: http://hg.mozilla.org/comm-central/rev/18fb544d19c1
Assignee: nobody → mikekaganski
Status: NEW → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 11.0
You need to log in
before you can comment on or make changes to this bug.
Description
•