687885 - Don't use resetUseCount() outside of ifdef JS_METHODJIT

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Landry Breuil (:gaston)]

Followup to that commit : http://hg.mozilla.org/mozilla-central/rev/9ca3d16d575c

Build now fails on sparc64 (where JS_METHODJIT is undef) with :
js/src/jsinfer.cpp:6041: error: 'struct JSScript' has no member named 'resetUseCount'

See http://buildbot.rhaalovely.net/builders/mozilla-central-sparc64/builds/165/steps/build/logs/stdio

Imo the call should be included within JS_METHODJIT as the releaseScriptCode call upper.

Comment 1

[Landry Breuil (:gaston)]

Attachment: Proposed fix

Trying that patch here, results in http://buildbot.rhaalovely.net/builders/mozilla-central-sparc64/builds/166/steps/build/logs/stdio and apparently it fixes the build issue.

Comment 2

[Brian Hackett [Laid off!]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/21a39c2f9060

Comment 3

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/21a39c2f9060

Comment 4

[Ed Morley [:emorley]]

Is possibly the cause of the macosx-debug_spidermonkey-shark builds going orange: (NB you need to use TBPL &usetinderbox=1 so the logs show up, due to bug 685299)

https://tbpl.mozilla.org/?tree=Mozilla-Inbound&usetinderbox=1&jobname=spidermonkey&rev=21a39c2f9060

http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1316539496.1316543246.4464.gz

The last JS touching changing before this (https://tbpl.mozilla.org/?tree=Mozilla-Inbound&usetinderbox=1&jobname=spidermonkey&rev=5a3e49205389) was green.