Closed
Bug 688416
Opened 13 years ago
Closed 13 years ago
Test for Bug 502959 relies on XHR event listener being an nsIDOMEventListener
Categories
(Core :: XPConnect, defect)
Core
XPConnect
Tracking
()
RESOLVED
FIXED
mozilla10
People
(Reporter: khuey, Assigned: khuey)
References
Details
Attachments
(1 file, 1 obsolete file)
|
1.20 KB,
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
The test for Bug 502959 expects that if it sets and then retrieves the onreadystatechange event handler on an XHR object that it will receive a wrapped nsIDOMEventListener. After Bug 687332 this is no longer the case. Wrappers scare me, so asking for r+ on this test change to make sure it's still testing what it should be.
Attachment #561705 -
Flags: review?(mrbkap)
|
Assignee | |
Comment 1•13 years ago
|
||
Comment on attachment 561705 [details] [diff] [review] Patch So, now that I understand what this test does I think I know how to continue testing that functionality.
Attachment #561705 -
Attachment is obsolete: true
Attachment #561705 -
Flags: review?(mrbkap)
|
|
Assignee | |
Comment 2•13 years ago
|
||
What do you know, dom traversal *is* actually good for something!
|
||
Updated•13 years ago
|
Attachment #562552 -
Flags: review?(mrbkap) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/79f7d54a4cc3
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in
before you can comment on or make changes to this bug.
Description
•