688621 - [TABLETUI] Try to grab higher quality favicons for the URL bar, awesomebar and tab menu

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: General, defect)

Comment 1

[Matt Brubeck (:mbrubeck)]

As far as I can tell, we already do this.  You can verify this on pages that provide large favicons, like about:home or http://limpet.net/mbrubeck/

Comment 2

[Aaron Train [:aaronmt]]

Majority of favicon's are drawn blurry and pixelated still. Is there anything that can be done to match the quality that one would see in the stock browser?

Comment 3

[Matt Brubeck (:mbrubeck)]

(In reply to Aaron Train [:aaronmt] from comment #2)
> Majority of favicon's are drawn blurry and pixelated still. Is there
> anything that can be done to match the quality that one would see in the
> stock browser?

Currently we show favicons at 32x32 pixels, so for the majority of sites (which provide only 16x16 icons) we must enlarge the icons to 200%.  The stock browser shows favicons at 16x16 pixels.  We could change our tablet theme to do the same.

Comment 4

[Lucas Rocha (:lucasr)]

I think we should change our favicon to be 16x16 and only show the 32x32 if it's available. We're having pixelated favicon most of the time.

Comment 5

[Ian Barlow (:ibarlow)]

Can we do a test build with 16x16 favicons?

Comment 6

[Matt Brubeck (:mbrubeck)]

Attachment: screenshot with 16px icon

This screenshot shows a patch that just changes the icon size from 32px to 16px in the Honeycomb theme.  (Test build coming soon.)  As you can see, it doesn't look great with the current layout.  We'd need to change the alignment and spacing too.

Comment 7

[Matt Brubeck (:mbrubeck)]

Attachment: screenshot with 16px icon, really

These are not the droids you are looking for.

Comment 8

[Ian Barlow (:ibarlow)]

Thanks mbrubeck.

I think i would prefer pixelated 32px icons to this.

Comment 9

[Matt Brubeck (:mbrubeck)]

http://people.mozilla.com/~mbrubeck/fennec-small-icons.apk is a test build, if anyone wants to try it.  Favicons in the awesomebar popup are affected too.  (The change is honeycomb-only; it still uses 32px icons on Froyo/Gingerbread.)

Comment 10

[Ian Barlow (:ibarlow)]

Yeah, that feels pretty strange. Lucas and I were just talking about the idea of using 32px icons when we can get them, and placing a border around 16px ones , rather than stretching them I'd rather try something like that, because this doesn't look too great :)

Comment 11

[Lucas Rocha (:lucasr)]

Filed bug 689238 to track the dynamic 32px background idea by the way.