688785 - No character number limitation for review title and body

Status: RESOLVED WONTFIX

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Cristian Boldan]

Attachment: max_character_for_review.png

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:6.0.2) Gecko/20100101 Firefox/6.0.2
Build ID: 20110902133214

Steps to reproduce:

Steps to reproduce:

1.	Select reviews for an available add-on – e.g. https://addons.allizom.org/en-US/firefox/i/addon/adblock-plus/reviews/
2.	Click the 'Write a new review' button
3.	In the Add a Review page, type in title and body for the review using more than 80 characters for each field.
4.     Select a rating for the add-on
5.     Click the Submit Review button.
6.     Verify that review is displayed correctly.



Actual results:

If more than 80 characters are used for title/review, the review is not displayed correctly.


Expected results:

Fields should be limited to the maximum number of characters that can be displayed without issues.

Comment 1

[Potch [:potch]]

Where does this expectation originate? First I've heard of it.

Comment 2

[Potch [:potch]]

Reviews should ideally contain white-space and newlines, which will wrap appropriately.

Comment 3

[Christopher Van Wiemeersch [:cvan]]

What potch said.

Unless someone types some character 80 times, this won't happen. And even if it does, we truncate since there's no whitespace for it to wrap. That is fine.

Just so we don't get super-super long titles, I've added a constraint to max out at 255 characters:

https://github.com/jbalogh/zamboni/commit/726b31c

Comment 4

[Christopher Van Wiemeersch [:cvan]]

I've reverted the max-length constraint. We can revisit input constraints later, but this bug still stands as invalid.

https://github.com/jbalogh/zamboni/commit/7eea35d