689025 - Language button has a label referencing location of intl.properties

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

Attachment: Nightly (09/25)

Mozilla/5.0 (Android; Linux armv7l; rv:9.0a1) Gecko/20110925 Firefox/9.0a1 Fennec/9.0a1

In preferences, the 'Language' button has a label with a value: chrome://global/locale/intl.properties.

See screenshot.

Comment 2

[Wesley Johnston (:wesj)]

Attachment: Patch

My original concern here was when users download and install a locale and then return to the Prefs pane. We don't have a nice language string to show, so instead we fall back to showing the locale code. Apparently when we're using auto-detection that can result in this strangeness?

This makes that fallback only happen if the pref has a user set value.

Alternatively, instead of listening for pref change notifications, I could fire off an observer notification from the locale picker when "Continue" (or Cancel, etc) was pressed that had the current selected locale name attached.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 562464 [details] [diff] [review]
Patch

>-    let selectedLocale = Services.prefs.getCharPref("general.useragent.locale");
>+    let selectedLocale = chrome.getSelectedLocale("browser");
>+    // the chrome locale may not have updated yet if the user is installing a new
>+    // locale. if the pref has a user set value, use it instead

Add a blank line before the comment

Comment 4

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/65ae0b5132e5

Comment 5

[Cristian Nicolae (:xti)]

Verified fixed on:
Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110927
Firefox/9.0a1 Fennec/9.0a1
Device: Acer ICONIA A500
OS: Android 3.1