Closed
Bug 689252
Opened 13 years ago
Closed 13 years ago
cleanup/remove geo.wifi.* preferences
Categories
(Core :: DOM: Geolocation, defect)
Core
DOM: Geolocation
Tracking
()
RESOLVED
FIXED
mozilla9
People
(Reporter: dougt, Assigned: dougt)
References
Details
(Keywords: addon-compat)
Attachments
(1 file)
2.97 KB,
patch
|
jdm
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•13 years ago
|
||
Attachment #562575 -
Flags: review?(josh)
Updated•13 years ago
|
Attachment #562575 -
Flags: review?(josh) → review+
Assignee | ||
Comment 2•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ade33e515f46
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•13 years ago
|
Target Milestone: --- → mozilla9
Comment 3•13 years ago
|
||
Comment on attachment 562575 [details] [diff] [review] patch v.1 >+ let providerUrlBase = "https://maps.googleapis.com/maps/api/browserlocation/json"; Is it legally OK that every Mozilla-based app, including SeaMonkey and any XULRunner application that would hook up Geolocation, is now automatically using this provider? I thought Google explicitly only lets us use this for actual Firefox? I'm surely OK with having it be used by everybody, but I'm worried that Google may not agree with me here.
Comment 5•13 years ago
|
||
Why is this no longer configurable? There's not a single comment in this bug explaining the rationale. This kills projects like Geomena dead. http://geomena.org/
Comment 6•13 years ago
|
||
A configurable geolocation provider is a critical freedom in locative web technology. Its as if Ubuntu decided to remove /etc/resolv.conf and hard code the DNS server IP address. Please restore this option. Both Firefox and Opera support this setting.. I started the geomena.org project to create a creative commons licensed alternative to the wifi location databases of google, apple, and skyhook. Having the geo.wifi.url setting makes this possible.
Comment 7•13 years ago
|
||
I would appreciate explanation too.
Assignee | ||
Comment 8•13 years ago
|
||
The preference is still honored, it is just not in about:config.
Comment 9•13 years ago
|
||
How is a firefox user meant to configure the geolocation provider, then?
Comment 10•13 years ago
|
||
Looking at the patch, we have this:
> - let providerUrlBase = Services.prefs.getCharPref("geo.wifi.uri");
> + let providerUrlBase = "https://maps.googleapis.com/maps/api/browserlocation/json";
> + try {
> + providerUrlBase = Services.prefs.getCharPref("geo.wifi.uri");
> + } catch (x) {};
So, the default value is no longer in the preferences, but the code still tries to see if there's anything set there and uses that value instead, if set.
In about:config it should still be possible to create a string preference with that name, and it should work correctly.
Comment 11•13 years ago
|
||
Thanks for pointing that out.
Assignee | ||
Comment 12•13 years ago
|
||
yup. we currently do this for testing.
Comment 13•13 years ago
|
||
I should have take a look in the patch. Thanks.
Comment 14•13 years ago
|
||
(In reply to Sonny Piers from comment #13) > I should have take a look in the patch. > Thanks. No worries. This confusion happens more easily when bugs don't have any comments or explanation. It got me too :)
You need to log in
before you can comment on or make changes to this bug.
Description
•