689367 - layout/build/nsLayoutModule.cpp:761:1: warning: 'kNS_CANVASRENDERINGCONTEXT2DAZURE_CID' defined but not used

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Daniel Holbert [:dholbert]]

bug 651858 added NS_CANVASRENDERINGCONTEXT2DAZURE_CID and a "NS_DEFINE_NAMED_CID()" line for it, as shown here:
   https://hg.mozilla.org/mozilla-central/rev/a8171812fe05#l6.2
... but it never uses it beyond those two lines, as shown here:
https://mxr.mozilla.org/mozilla-central/search?string=CANVASRENDERINGCONTEXT2DAZURE_CID&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

(compare to e.g. the same search with s/2DAZURE/WEBGL/, which turns up 3 usages:
https://mxr.mozilla.org/mozilla-central/search?string=NS_CANVASRENDERINGCONTEXTWEBGL_CID
)

It looks like we never needed this CID and can delete it. (unless we should perhaps be using it but forgot to?)

Comment 1

[Daniel Holbert [:dholbert]]

I noted in the bug title but forgot to mention in comment 0 -- this bug triggers the following build warning:
> layout/build/nsLayoutModule.cpp:761:1: warning: 'kNS_CANVASRENDERINGCONTEXT2DAZURE_CID' defined but not used
https://tbpl.mozilla.org/php/getParsedLog.php?id=6559103&tree=Firefox

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: fix: remove unused CID

This patch just removes the unused CID.

(Bas, let me know (and feel free to take this) if there's something else that needs to be done here.)

Comment 3

[Bas Schouten (:bas.schouten)]

Comment on attachment 562584 [details] [diff] [review]
fix: remove unused CID

Review of attachment 562584 [details] [diff] [review]:
-----------------------------------------------------------------

Looks right to me!

Comment 4

[Daniel Holbert [:dholbert]]

Oops, I somehow missed that this got r+. :)  Sorry for delay in landing.

After I do a sanity-check to be sure this still builds, I'll push.

Comment 5

[Daniel Holbert [:dholbert]]

Landed: https://hg.mozilla.org/integration/mozilla-inbound/rev/6f440ff5247f

BTW, I have the 'eol' hg extension on the machine I'm pushing from, and that caught & fixed some DOS line-endings in 3 lines of contextual code (for NS_CANVASRENDERINGCONTEXT2DTHEBES_CID) when I did a final qref on the patch.  (those were the only lines with DOS line-endings in the whole file)

I left that line-ending-fix in the patch when pushing, since it doesn't affect behavior and DOS line endings are evil.

Comment 6

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/mozilla-central/rev/6f440ff5247f