689404 - Changes to inline settings broke existing Firefox Mobile add-ons

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

bug 669390 changed <setting type="control"> to only allow <button> children and added <setting type="multi"> to handle <menulist> and <radiogroup> children.

This breaks many Firefox Mobile add-ons which use <setting type="control"> for <menulist> children.

We need a way to keep <setting type="control"> to keep working for add-on compatibility. Ideas?

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

One simple idea is to allow <setting type="control"> to have <menulist> children. Keep <setting type="multi"> as is, allowing <menulist> too.

This would allow old code still use the old binding, but new code will use the new binding.

Comment 2

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Yea, that's the easiest way (er, and the only way?). In one of the reviews, I think I explicitly asked for <setting type="control"> to stop including <menulist>, since it was something we didn't want to support forever. But if that's causing pain...

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

It is causing pain. We can work to get add-ons using the new binding, but we can't go cold turkey now.

This affects Fx8, which becomes "Beta" tomorrow/today.

Comment 4

[Dave Townsend [:mossop]]

Blair do you have time to put together a patch for this? We need to get it in nightlies a.s.a.p. so we can get the confidence to push it to the betas.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

I am trying a patch too

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

This patch merely adds "menulist" back to the allowed children of <setting type="control">. This means the developer is responsible for handling the saving and loading of the preference to the control.

If the developer wants to let the binding handle the preference syncing, they should use <setting type="multi">

This patch does correct the problem in Firefox Mobile. We should consider this a compatibility fix only. Let's not try to make type="control" into something bigger than it already is.

Comment 7

[Geoff Lankow (:darktrojan)]

Attachment: patch

My patch is better! :-P

And also already on try. https://tbpl.mozilla.org/?tree=Try&rev=5c3a17a73d94

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ac92a6d8297c

Comment 9

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/mozilla-central/rev/ac92a6d8297c

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

Thanks for the quick turn around guys!

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Mark, do you have an example extension which was broken?

Comment 12

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Henrik Skupin (:whimboo) from comment #11)
> Mark, do you have an example extension which was broken?

Bigger Text, by Matt Brubeck is one I tested. There are a few others too. Basically any add-on for Fennec that supplied it's own options is likely to fail.

Comment 13

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 562655 [details] [diff] [review]
patch

This patch was landed on Fx9 before Aurora, so it's already on Aurora now. We do need it on Beta though.

Safe, easy patch - with tests!

Comment 14

[LegNeato]

http://hg.mozilla.org/releases/mozilla-beta/rev/7b8d7d4b1c90

Comment 15

[Henrik Skupin [:whimboo][⌚️UTC+1]]

QA should track this fix across branches. Ioana, can one of you please verify this fix on the target branches, once it has been landed? Thanks.

Comment 16

[Andreea Pod]

Add-ons are working fine, including Bigger Text add-on. 

Verified fixed on Aurora 9 and Firefox 8 Beta 3: 
Mozilla /5.0 (Android;Linux armv7l;rv:9.0a2) Gecko/20111012 Firefox/9.0a2 Fennec/9.0a2  and  
Mozilla /5.0 (Android;Linux armv7l;rv:8.0) Gecko/20111011 Firefox/8.0 Fennec/8.0

Comment 17

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Geoff, I assume there is no manual test necessary? Please update the flag accordingly.