Closed
Bug 689595
Opened 13 years ago
Closed 6 years ago
update CI build code to work with BB or Jenkins
Categories
(Tamarin Graveyard :: Build Config, defect, P3)
Tracking
(Not tracked)
RESOLVED
WONTFIX
Q1 12 - Brannan
People
(Reporter: trbaker, Assigned: trbaker)
References
Details
Attachments
(3 files, 5 obsolete files)
4.42 KB,
patch
|
dschaffe
:
review+
|
Details | Diff | Splinter Review |
2.12 KB,
text/plain
|
trbaker
:
review+
|
Details |
23.92 KB,
patch
|
Details | Diff | Splinter Review |
A few problems when using compile-generic.sh from within Jenkins 1. the script creates a builds dir outside of the repo, which is causing problems because is outside of the "workspace" in Jenkins 2. I don't want to copy the builds to asteam by default. If I want to archive artifacts I can do it via an artifact publisher 3. nor do I want to delete the objdir
Assignee | ||
Updated•13 years ago
|
Summary: add mechanism to skip uploading shells to asteam and not delete objdir → compile-generic.sh problems when used within Jenkins
Assignee | ||
Comment 1•13 years ago
|
||
Attachment #562793 -
Flags: review?(dschaffe)
Assignee | ||
Comment 2•13 years ago
|
||
Attachment #562793 -
Attachment is obsolete: true
Attachment #562793 -
Flags: review?(dschaffe)
Assignee | ||
Comment 3•13 years ago
|
||
Attachment #562798 -
Attachment is obsolete: true
Assignee | ||
Comment 4•13 years ago
|
||
this passed in the sandbox
Attachment #562800 -
Attachment is obsolete: true
Attachment #562813 -
Flags: review?(dschaffe)
Updated•13 years ago
|
Attachment #562813 -
Flags: review?(dschaffe) → review+
Assignee | ||
Comment 5•13 years ago
|
||
Attachment #562813 -
Attachment is obsolete: true
Attachment #563477 -
Flags: review?(dschaffe)
Comment 6•13 years ago
|
||
Comment on attachment 563477 [details] [diff] [review] patch to get compile and test working on mac and windows in jenkins in compile-generic.sh did you mean to remove the last line rm -fr objdir I'm not convinced pre-pending the existing INCLUDE, LIB, LIBPATH values is good since it may create confusing situations. Like we should either require the values to be set correctly on the machine and we assume they are already set or require the script to set the values. Combining the two is confusing.
Attachment #563477 -
Flags: review?(dschaffe) → review+
Assignee | ||
Updated•13 years ago
|
Summary: compile-generic.sh problems when used within Jenkins → update CI build code to work with BB or Jenkins
Assignee | ||
Comment 7•13 years ago
|
||
patch applies to: https://github.com/jenkinsci/mercurial-plugin commit 385b155c2366cc22f479b5288183bf853022dcee Author: Jesse Glick <jesse.glick@oracle.com> Date: Fri Sep 9 16:09:38 2011 -0400
Assignee | ||
Comment 8•13 years ago
|
||
(In reply to Dan Schaffer from comment #6) > in compile-generic.sh did you mean to remove the last line rm -fr objdir Yes, I am archiving the artifact from there are reusing it in downstream jobs. This is to work around the BB system putting the shells in a /builds/ dir outside the repo. In Jenkins, I can't get outside of WORKSPACE, so addressing the shell from objdir is the intent. > I'm not convinced pre-pending the existing INCLUDE, LIB, LIBPATH values is > good since it may create confusing situations. Like we should either > require the values to be set correctly on the machine and we assume they are > already set or require the script to set the values. Combining the two is > confusing. At the heart of it is that jenkins is really flexible in letting you add and and remove nodes at will to scale up or down. Most/all of our buildbot config is in hg, while it won't be practical to use the same mechanisms for Jenkins. My thoughts on best practices for Jenkins are still formulating, but artificially constraining ourselves with such a flexible tool seems like the wrong approach.
Assignee | ||
Updated•13 years ago
|
Attachment #563514 -
Flags: review?(dschaffe)
Updated•13 years ago
|
Attachment #563514 -
Flags: review?(dschaffe) → review+
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → trbaker
Flags: flashplayer-qrb+
Target Milestone: --- → Q1 12 - Brannan
Comment 9•13 years ago
|
||
Attachment #566303 -
Flags: review?(trbaker)
Assignee | ||
Updated•13 years ago
|
Attachment #566303 -
Flags: review?(trbaker) → review+
Assignee | ||
Comment 10•13 years ago
|
||
consolidated patch to bring TR up to date with HM build changes
Attachment #563477 -
Attachment is obsolete: true
Attachment #571009 -
Flags: review?(brbaker)
Comment 11•13 years ago
|
||
changeset: 6832:7cc3acef01d7 user: Brent Baker <brbaker@adobe.com> summary: Update to latest jenkins tweaks based on bz:689595 http://hg.mozilla.org/tamarin-redux/rev/7cc3acef01d7
Comment 12•12 years ago
|
||
Comment on attachment 571009 [details] [diff] [review] patch from HM repo removing review. Not sure how much of this is still to land. Most of it has already landed in tamarin-redux via the float merge
Attachment #571009 -
Flags: review?(brbaker)
Updated•6 years ago
|
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•