689598 - Implement downloadable device blacklisting for Android

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Ali Juma [:ajuma]]

We currently implement a only hard-coded device blacklist in GfxInfo. We should add support for a downloadable blacklist.

Comment 1

[Doug Sherk (:drs) (inactive)]

Attachment: Patch v1.0, enable downloadable blacklist on Android devices.

Setting reviewer to bjacob for now, talking with joe to see if he can review it instead.

This enables the downloadable blacklist on Android devices. It was already enabled, but wasn't being processed. Note that this depends on the patch in bug 704710.

Also, this shouldn't be landed yet. We still have to deal with the issues reported in bug 700124 first.

Comment 2

[Doug Sherk (:drs) (inactive)]

Attachment: Patch v1.1, enable downloadable blacklist on Android devices.

Please review again, there were some changes made to support using Android SDK versions as the driver version field.

Comment 3

[Doug Sherk (:drs) (inactive)]

Try push: https://tbpl.mozilla.org/?tree=Try&rev=cffd58590c65

Comment 4

[Joe Drew (not getting mail)]

Comment on attachment 577861 [details] [diff] [review]
Patch v1.1, enable downloadable blacklist on Android devices.

Review of attachment 577861 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/src/android/GfxInfo.cpp
@@ +104,5 @@
> +    mAdapterDescription.Append(NS_LITERAL_STRING("', Manufacturer: '"));
> +    if (mozilla::AndroidBridge::Bridge()->GetStaticStringField("android/os/Build", "MANUFACTURER", str))
> +      mAdapterDescription.Append(str);
> +    mAdapterDescription.Append(NS_LITERAL_STRING("', Hardware: '"));
> +    PRInt32 version; // the HARDWARE field isn't available on Android SDK < 8

Maybe insert a blank line here.

@@ -297,5 @@
> -  // For now, we don't implement the downloaded blacklist.
> -  if (aDriverInfo.Length()) {
> -    *aStatus = nsIGfxInfo::FEATURE_NO_INFO;
> -    return NS_OK;
> -  }

Be sure that we don't return any built-in blocklist items (eg hard-coded in widget/src/android/GfxInfo.cpp) if aDriverInfo has any items in it. This makes sure we don't set our blacklist prefs on a downloaded blocklist ping unless they actually apply to us.

Comment 5

[Doug Sherk (:drs) (inactive)]

Attachment: Patch v1.2, enable downloadable blacklist on Android devices.

Addressed code review, +r carried.

Comment 6

[Doug Sherk (:drs) (inactive)]

Try push: https://tbpl.mozilla.org/?tree=Try&rev=abe278c327db

Comment 7

[Doug Sherk (:drs) (inactive)]

Attachment: Patch v1.0, fix crash reporter on Android.

Refactored crash report annotation to happen after Init because with changes in "enable downloadable blacklist on Android devices", all device info is cached on Init.

Comment 8

[Benoit Girard (:BenWa)]

Comment on attachment 578763 [details] [diff] [review]
Patch v1.0, fix crash reporter on Android.

:D

Comment 9

[Doug Sherk (:drs) (inactive)]

Attachment: Patch v1.1, fix crash reporter on Android.

Rebased/unbitrotted, +r carried.

Comment 10

[Doug Sherk (:drs) (inactive)]

https://tbpl.mozilla.org/?rev=fe937bac6e75

Comment 11

[Doug Sherk (:drs) (inactive)]

https://hg.mozilla.org/mozilla-central/rev/b9c1b8afb35a

Comment 12

[Benoit Jacob [:bjacob] (mostly away)]

Backed out from beta only:
http://hg.mozilla.org/releases/mozilla-beta/rev/544f5bc26164
See bug 711656 for explanation.

Comment 13

[Benoit Jacob [:bjacob] (mostly away)]

http://hg.mozilla.org/releases/mozilla-beta/rev/9af0904f0486 as well.