689626 - Brief flash of out-of-position content when keyboard opens with OGL layers on Galaxy Tab

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Joe Drew (not getting mail)]

This seems the same as bug 621745, but it persists on my Galaxy Tab despite the recent fixes.

Opening and closing the awesomescreen causes a brief flash of out-of-position content; either the texture is drawn too high or too low, depending on whether you're opening or closing the keyboard.

Comment 1

[Ali Juma [:ajuma]]

Attachment: surfaceChanged shouldn't cause a frame of the previous size to be rendered on Honeycomb

In Bug 621745, it was discovered that when a surfaceChanged event occurs, we still need to draw one more frame at the old size since the buffer size only changes after the next eglSwapBuffer.

However, in Honeycomb, the buffer size is changing immediately. So when we draw a frame of the old size, we are either drawing a frame that is too large (e.g. when the keyboard appears) or too small (e.g. when the keyboard disappears).

This patch modifies the behaviour introduced in Bug 621745 so that we only draw a frame of the old size on pre-Honeycomb.

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 566532 [details] [diff] [review]
surfaceChanged shouldn't cause a frame of the previous size to be rendered on Honeycomb

It would be nice to know what change caused this, but that will at least need to wait til Ice Cream Sandwich.

Comment 3

[Ali Juma [:ajuma]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/46ce491cec60

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/46ce491cec60