689847 - Expose active state on current item of selectable widgets

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

This is requirement of ARIA spec - http://www.w3.org/TR/wai-aria-implementation/#keyboard-focus_aria-activedescendant

If ARIA widgets needs that native widgets should follow to be consistent.

IA2 provides IA2_STATE_ACTIVE which is described as:

This state can be used to indicate the current active item in a container, even 
  if the container itself is not currently active. In other words this would indicate
  the item that will get focus if you tab to the container.

Comment 1

[alexander :surkov (:asurkov)]

Attachment: patch

besides we follow the spec this state should be useful for virtual cursor implementations when AT navigates the document without focus changing.

Comment 2

[alexander :surkov (:asurkov)]

Attachment: patch2

actually ARIA part was implemented in bug 403260. Make items of all widgets to expose active state.

Comment 3

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 577236 [details] [diff] [review]
patch2

Review of attachment 577236 [details] [diff] [review]:
-----------------------------------------------------------------

r=me. nice.

::: accessible/src/base/nsAccessible.cpp
@@ +1548,5 @@
> +    // descendant is the current one that would get focus if the user navigates
> +    // to the container widget.
> +    nsAccessible* widget = ContainerWidget();
> +    if (widget && widget->CurrentItem() == this)
> +      state |= states::ACTIVE;

Very nice change (I forgot about CurrentItem).

Comment 4

[alexander :surkov (:asurkov)]

inbound land - https://hg.mozilla.org/integration/mozilla-inbound/rev/3a3633f1458c

Comment 5

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/3a3633f1458c