689899 - fix flickering of warning box on start page

Status: VERIFIED FIXED

(support.mozilla.org :: Knowledge Base Software, task)

Description

[Kadir Topal [:atopal]]

The warning box on the start page shows all content first and then hides it. That is rather confusing and on slow machines/connections people have time to read the full warning before it goes away.

Please insert that box after the page is loaded, and only show the appropriate showfor content instead of hiding it after loading it.

Comment 1

[Ricky Rosario [:rrosario, :r1cky]]

I don't believe we want to add ajax here. We need to figure out how to have this hidden by default. It is probably tricky given that this is using {for} and it's related js for showing/hiding. We might need to add a hidden-by-default class or something like that.

Comment 2

[Kadir Topal [:atopal]]

Okay, then maybe deferred display: that box can be wrapped in it's own class, hidden by default and displayed after page load is complete. Would even be more effective ,if it would pop up, flash a bright color and fade to current color.

Comment 3

[Ricky Rosario [:rrosario, :r1cky]]

https://github.com/jsocol/kitsune/commit/1177f6859ef25ccebf577605a46646ae8bb53281

Comment 4

[Kadir Topal [:atopal]]

So, what solution did you go with? In the check-in it looks like the box is set to display: none. Is there accompanying JS to switch it on after the page is loaded? I'm just asking because I can still see the flicker on staging.

Comment 5

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to Kadir Topal [:atopal] from comment #4)
> So, what solution did you go with? In the check-in it looks like the box is
> set to display: none. Is there accompanying JS to switch it on after the
> page is loaded? I'm just asking because I can still see the flicker on
> staging.

Yes, the SHOWFOR script will reset the display appropriately. If you are seeing it after clearing cache, this may not have worked then :(.

Comment 6

[Ricky Rosario [:rrosario, :r1cky]]

Yeah, I see it on stage. I will try something else...

Comment 7

[Ricky Rosario [:rrosario, :r1cky]]

https://github.com/jsocol/kitsune/commit/770ab6d2467d79072ad4465778ed85ca1f007a0c

Comment 8

[Kadir Topal [:atopal]]

Awesome, no more flickering :)