Closed
Bug 689928
Opened 13 years ago
Closed 13 years ago
White space in the left side of the tab bar
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox9 affected, firefox10 fixed, fennec9+)
VERIFIED
DUPLICATE
of bug 691541
Firefox 10
People
(Reporter: andreea.pod, Assigned: mfinkle)
References
Details
(Keywords: regression)
Attachments
(4 files)
56.15 KB,
image/png
|
Details | |
71.96 KB,
image/png
|
Details | |
1.06 KB,
patch
|
mbrubeck
:
review+
mfinkle
:
approval-mozilla-aurora-
|
Details | Diff | Splinter Review |
10.45 KB,
image/jpeg
|
Details |
Mozilla /5.0 (Android;Linux armv7l;rv:10.0a1) Gecko/20110928 Firefox/10.0a1 Fennec/10.0a1 Device: LG Optimus 2X (Android 2.2) Steps to reproduce: 1. Open Fennec with a new profile 2. Look at the left side of the screen while the first-run animation is running Actual result: you can see a white space from top to bottom (screenshot1) Expected results: no white spaces in the sidebars Notes: - the page is not rendered correctly in the left side also after you close and open the browser(screenshot2) - reproducible on Aurora too: Mozilla /5.0 (Android;Linux armv7l;rv:9.0a2) Gecko/20110928 Firefox/9.0a2 Fennec/9.0a2
Reporter | ||
Comment 1•13 years ago
|
||
Comment 2•13 years ago
|
||
I don't see this on my Galaxy SII, nor a Nexus S. Can you trace a regression?
Assignee | ||
Comment 3•13 years ago
|
||
I see this on my Nexus One and Galaxy Tab (7") My guess is it's either a regression from bug 678480 or bug 686417. Can we try nightlies to find the regression range?
Keywords: regression,
regressionwindow-wanted
Comment 4•13 years ago
|
||
I can't reproduce this in desktop Fennec, even after selecting the Froyo skin and setting layout.css.dpi=240 in prefs.js.
Comment 5•13 years ago
|
||
I also can't reproduce this on T-Mobile G2 (Android 2.3) running the latest trunk Nightly 10.0a1 (20110928).
Comment 6•13 years ago
|
||
I do see this on Samsung Verizon Galaxy Tab 7" (Android 2.2).
Reporter | ||
Comment 7•13 years ago
|
||
This started happening since bug 678480 was fixed. Last build that wasn't with this problem: http://hg.mozilla.org/mozilla-central/rev/259d1556c221 First build with this problem: http://hg.mozilla.org/mozilla-central/rev/c71229984353 http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=259d1556c221&tochange=c71229984353
Reporter | ||
Updated•13 years ago
|
Keywords: regressionwindow-wanted
Updated•13 years ago
|
Updated•13 years ago
|
Assignee: nobody → wjohnston
Assignee | ||
Updated•13 years ago
|
Assignee | ||
Comment 9•13 years ago
|
||
Who can work on this? It's needed in Aurora ASAP.
Updated•13 years ago
|
Assignee: wjohnston → mbrubeck
Version: Trunk → Firefox 9
Assignee | ||
Comment 10•13 years ago
|
||
This patch removes the fixed width/height in browser.xul causing less resizes. This fixes the content offset problem and might even help startup a tiny bit. Test build is here: http://people.mozilla.com/~mfinkle/fennec/fennec-10.a1-nofixedsize.apk
Assignee: mbrubeck → mark.finkle
Attachment #565647 -
Flags: review?(mbrubeck)
Updated•13 years ago
|
Attachment #565647 -
Flags: review?(mbrubeck) → review+
Comment 11•13 years ago
|
||
Comment on attachment 565647 [details] [diff] [review] patch Nominating for Aurora 9. This is a low-risk mobile only change that fixes a user-visible regression in the first-run animation on Android 2.2 devices. The change just removes a hard-coded size from our main XUL window so that it will not need to resize again during startup. (The hard-coded size has always been useful only on desktop Fennec builds.)
Attachment #565647 -
Flags: approval-mozilla-aurora?
Comment 12•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/194720ba054f
Status: NEW → RESOLVED
Closed: 13 years ago
status-firefox10:
--- → fixed
status-firefox9:
--- → affected
Resolution: --- → FIXED
Target Milestone: --- → Firefox 10
Comment 13•13 years ago
|
||
This is still visible on (10/11 Nightly); albeit the thin line is now grey.
Updated•13 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 14•13 years ago
|
||
The fix for this has landed and won't be backed out. It did fix the issues for personal builds. We are working through the issues with nightly builds in bug 691541. Let's leave this bug and move to bug 691541. Not sure if FIXED or DUPE is better for this one. Choosing DUPE for now.
Status: REOPENED → RESOLVED
Closed: 13 years ago → 13 years ago
Resolution: --- → DUPLICATE
Assignee | ||
Comment 15•13 years ago
|
||
Comment on attachment 565647 [details] [diff] [review] patch This hasn't actually fixed the problem on nightlies.
Attachment #565647 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora-
Updated•13 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•