Closed
Bug 689966
Opened 13 years ago
Closed 13 years ago
Custom Page has a double entry for Start Page option
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox9 fixed, fennec9+)
VERIFIED
FIXED
Firefox 9
People
(Reporter: xti, Assigned: mbrubeck)
References
Details
(Keywords: regression, Whiteboard: [pushed])
Attachments
(2 files)
43.08 KB,
image/png
|
Details | |
1.71 KB,
patch
|
wesj
:
review+
asa
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Build ID: Mozilla/5.0 (Android;Linux armv7l;rv:9.0a2)Gecko/20110928 Firefox/9.0a2 Fennec/9.0a2 Device: Samsung Galaxy S OS: Android 2.2 Build ID: Mozilla/5.0 (Android;Linux armv7l;rv:10.0a1)Gecko/20110928 Firefox/10.0a1 Fennec/10.0a1 Device: Samsung Galaxy S OS: Android 2.2 Steps to reproduce: 1. Open Fennec App 2. Browse to www.google.com 3. Go to Preferences > Start Page 4. Select Custom Page 5. Open a new tab and go to www.mozilla.com 6. Repeat step 3 Expected result: After step 4, no Start Page entry is duplicated. Actual result: Custom Page option is listed twice as you can see on the attached screenshot.
Updated•13 years ago
|
Assignee: nobody → wjohnston
Assignee | ||
Comment 1•13 years ago
|
||
Bug 658278 removed the prefs-languages element, but the preferences initialization code was still looking for it, so it ended up initializing stuff more than once.
Assignee | ||
Comment 2•13 years ago
|
||
Nominating for tracking-fennec. This regression affects Firefox 9 and may cause other subtler bugs. We should request approval to land this in Aurora when it has been reviewed and pushed.
Blocks: 658278
tracking-fennec: --- → ?
status-firefox9:
--- → affected
Keywords: regression
Version: Trunk → Firefox 9
Updated•13 years ago
|
tracking-fennec: ? → 9+
Comment 3•13 years ago
|
||
Comment on attachment 563166 [details] [diff] [review] patch Thanks matt!
Attachment #563166 -
Flags: review?(wjohnston) → review+
Assignee | ||
Comment 4•13 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/7cc26b83a57c
Whiteboard: [pushed]
Assignee | ||
Comment 5•13 years ago
|
||
Comment on attachment 563166 [details] [diff] [review] patch Requesting approval for Aurora 9. This fixes a regression introduced in Firefox 9. The symptoms are not serious, but they are user-visible, and the nature of the regression makes me think there may be more subtle symptoms that we haven't found yet. The fix is mobile-only, very localized, and safe. It removes a attempt to reference a non-existent XUL element.
Attachment #563166 -
Flags: approval-mozilla-aurora?
Comment 6•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7cc26b83a57c
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•13 years ago
|
Target Milestone: --- → Firefox 10
Updated•13 years ago
|
Attachment #563166 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 7•13 years ago
|
||
Pushed to Aurora for Firefox 9: https://hg.mozilla.org/releases/mozilla-aurora/rev/b9a6752584aa
Target Milestone: Firefox 10 → Firefox 9
Reporter | ||
Comment 8•13 years ago
|
||
Verified fixed on: Mozilla/5.0 (Android;Linux armv7l;rv:9.0a2)Gecko/20110930 Firefox/9.0a2 Fennec/9.0a2 Device: Samsung Galaxy S OS: Android 2.2
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•