689968 - CssLogic is slow at skipping UA rules for the unmatched selectors view

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Mihai Sucan [:msucan]]

CssLogic skips on a selector-by-selector basis those rules that come from UA style sheets, when building the array of unmatched selectors.

(note that a sheet has multiple rules, and each rule has multiple selectors!)

We need to skip UA sheets entirely from being processed when building the array of unmatched selectors. This will improve performance in all of the Style Inspector use cases, irrespective of the "Show only user styles" checkbox state.

Comment 1

[Mihai Sucan [:msucan]]

Attachment: proposed fix

This patch changes the location of where the system rules are skipped.

It seems that system rules have been skipped inside the CssPropertyInfo code path. It should be quite faster to skip the system style sheets entirely in the CssLogic code path, so they never get processed.

(I don't know when the change was made for systemRules to be skipped in the unmatched selectors view...)

All tests pass on my system.

Comment 2

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 563092 [details] [diff] [review]
proposed fix

yes!

Comment 3

[Mihai Sucan [:msucan]]

Thank you Rob!

Comment 4

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/integration/fx-team/rev/8bcf17f1aaed

Comment 5

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/mozilla-central/rev/8bcf17f1aaed