690199 - ARIA select widget should expose focusable state regardless the way they manage its children

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

Historically widgets like listboxes, trees never take a focus (while they have focusable items) but expose focusable state. ARIA widgets can be manage the focus by two ways: aria-activedescendant approach and focusable children approach. The former approach makes the widget focusable, the second one makes it non focusable by default. So the suggestion is expose focusable state on ARIA widget not depending on the way the widget manages it children. That makes ARIA widget consistent each with other and with native widget.

Comment 1

[alexander :surkov (:asurkov)]

Actually these roles should be covered:
* listbox
* grid
* tree
* treegrid

Perhaps I would add ARIA state map item like FocusableIfHasFocusableItem to handle all of them rather than hacking into Accessible class

Comment 2

[Max Li [:maxli]]

Attachment: Patch

Comment 3

[alexander :surkov (:asurkov)]

Comment on attachment 781181 [details] [diff] [review]
Patch

Review of attachment 781181 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/base/ARIAStateMap.cpp
@@ +331,5 @@
> +    {
> +      if (aElement->HasAttr(kNameSpaceID_None, nsGkAtoms::aria_disabled) &&
> +          aElement->AttrValueIs(kNameSpaceID_None, nsGkAtoms::aria_disabled,
> +                                nsGkAtoms::_true, eCaseMatters))
> +        *aState &= ~states::FOCUSABLE;

to stay on safe side I wouldn't remove FOCUSABLE state (for example when this state goes from native markup)

It seems you should do
if (aElement->HasDefinedARIAToken() && !aElemnet->AttrValueIs("false"))

::: accessible/tests/mochitest/states/test_aria.html
@@ +275,5 @@
> +  <a target="_blank"
> +     href="https://bugzilla.mozilla.org/show_bug.cgi?id=690199"
> +     title="ARIA select widget should expose focusable state regardless the way they manage its children">
> +    Mozilla Bug 690199
> +  </a>

pls keep bug numbers sorted

Comment 4

[Max Li [:maxli]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/35f1055fd217

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/35f1055fd217