690203 - eventtracer interferes with goQuitApplication on leopard

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[alice nodelman [:alice] [:anode]]

When the eventtracer tool is enabled goQuitApplication (part of the pageloader bundle) causes the browser to freeze instead of quit cleanly.

This is only on leopard test boxes.

Comment 1

[(not currently active) Ted Mielczarek]

I only have 10.6 here, so I can't reproduce this. Can you use Activity Monitor and sample the process when it's hung?

Comment 2

[alice nodelman [:alice] [:anode]]

http://pastebin.mozilla.org/1339490

I've been testing this on tools-r3-leopard-001, which is an ateam test box which I can give you access to - since I don't see any smoking gun in the sample process output.

Comment 3

[(not currently active) Ted Mielczarek]

Looks like it's sitting and waiting for the background thread to exit:
1202 mozilla::ShutdownEventTracing()

We must exit the event loop differently on Leopard somehow, such that the last event that the background thread sends doesn't get processed.

Comment 4

[(not currently active) Ted Mielczarek]

I reproduced the hang on that same Leopard slave. I pushed a patch to try, I'll test with those builds when they become available:
http://hg.mozilla.org/try/pushloghtml?changeset=6d5f900ee3da

Comment 5

[(not currently active) Ted Mielczarek]

Attachment: ensure that we unstick the event tracing thread when shutting down

I tested the try build on a 10.5 machine, and it worked fine. This patch just makes us signal the event tracer thread during shutdown, so that it doesn't get hung if it fires one last tracer event that never gets serviced.

Comment 6

[(not currently active) Ted Mielczarek]

http://hg.mozilla.org/integration/mozilla-inbound/rev/6b83e2e33b5a

Comment 7

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/6b83e2e33b5a