690419 - Script debugger picks the wrong highlighting engine in URLs with a query string

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Panos Astithas (he/him) [:past] (please ni?)]

The conditional that picks between JavaScript and HTML source highlighting should strip the query string from the URL first.

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

A similar issue is that the highlighting engine is not updated when the selected script is changed.

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Working patch

This patch fixes both issues.

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Working patch v2

Improved the mochitest a bit.

Comment 4

[Dave Camp (:dcamp)]

We're fetching source from necko, right?  Can we do this with server-provided content types rather than filename sniffing?

Comment 5

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Working patch v3

(In reply to Dave Camp (:dcamp) from comment #4)
> We're fetching source from necko, right?  Can we do this with
> server-provided content types rather than filename sniffing?

Yep, for non-local scripts we sure can. Thanks!

Comment 6

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: [in-fx-team] Working patch v4

Made a small test fix required after the last merge with fx-team.

Comment 7

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Diff between v3 and v4

These are the changes.

Comment 8

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/integration/fx-team/rev/7b6bf801d765

Comment 9

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/7b6bf801d765