Closed
Bug 690566
Opened 13 years ago
Closed 13 years ago
ShadowCanvasLayer::RenderLayer doesn't ApplyFilter for each tile
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla10
People
(Reporter: ajuma, Assigned: ajuma)
Details
Attachments
(1 file, 1 obsolete file)
16.55 KB,
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
It should really ApplyFilter after each texture tile is bound.
Assignee | ||
Comment 1•13 years ago
|
||
Attachment #563564 -
Flags: review?(bgirard)
Comment 2•13 years ago
|
||
Comment on attachment 563564 [details] [diff] [review] Make ShadowCanvasLayer::RenderLayer apply filter for each tile Passing the review along. We worked together on that patch.
Attachment #563564 -
Flags: review?(bgirard) → review?(jmuizelaar)
Comment 3•13 years ago
|
||
Comment on attachment 563564 [details] [diff] [review] Make ShadowCanvasLayer::RenderLayer apply filter for each tile we should see if we can associate the filter more closely with the texture image, because it is texture state and not glcontext state.
Attachment #563564 -
Flags: review?(jmuizelaar) → review-
Assignee | ||
Comment 4•13 years ago
|
||
In addition to associating filters with texture images, this also moves ApplyFilter from LayerOGL to GLContext and renames it to ApplyFilterToBoundTexture.
Attachment #563564 -
Attachment is obsolete: true
Attachment #564659 -
Flags: review?(jmuizelaar)
Comment 5•13 years ago
|
||
Comment on attachment 564659 [details] [diff] [review] Associate filters with texture images. Review of attachment 564659 [details] [diff] [review]: ----------------------------------------------------------------- I think this is clearer than before. I'd be interested to hear what others think.
Attachment #564659 -
Flags: review?(jmuizelaar) → review+
Assignee | ||
Comment 6•13 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/cdcfb799ff50
Target Milestone: --- → mozilla10
Comment 7•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/cdcfb799ff50
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•