Closed
Bug 690656
Opened 13 years ago
Closed 13 years ago
Stop creating QWidget in DragService ctor
Categories
(Core Graveyard :: Widget: Qt, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla10
People
(Reporter: romaxa, Assigned: romaxa)
Details
Attachments
(2 files, 1 obsolete file)
|
1.52 KB,
patch
|
dougt
:
review+
|
Details | Diff | Splinter Review |
|
4.44 KB,
patch
|
dougt
:
review+
|
Details | Diff | Splinter Review |
DragService creating toplevel QWidget in ctor which is bad and prevent gecko init in non-main thread
|
Assignee | |
Comment 1•13 years ago
|
||
|
||
Updated•13 years ago
|
Attachment #563657 -
Flags: review?(doug.turner) → review+
|
|
Assignee | |
Comment 2•13 years ago
|
||
Oh, found that we also should not install XEvent handler in non-main thread. Also added check new QWidget and prevent that calling in non-main thread.
Attachment #563662 -
Flags: review?(doug.turner)
|
|
Assignee | |
Comment 3•13 years ago
|
||
Attachment #563662 -
Attachment is obsolete: true
Attachment #563662 -
Flags: review?(doug.turner)
Attachment #563675 -
Flags: review?(doug.turner)
|
|
||
Updated•13 years ago
|
Attachment #563675 -
Flags: review?(doug.turner) → review+
|
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
|
||
Comment 4•13 years ago
|
||
In my queue, which is heading to try first then inbound :-) https://tbpl.mozilla.org/?tree=Try&rev=a8fbb2a76633
Keywords: checkin-needed
|
|
||
Comment 5•13 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/e64926f9e278 https://hg.mozilla.org/integration/mozilla-inbound/rev/776a816fe364
Target Milestone: --- → mozilla10
|
||
Comment 6•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e64926f9e278 https://hg.mozilla.org/mozilla-central/rev/776a816fe364
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•