690668 - TEST-UNEXPECTED-FAIL | c:\talos-slave\test\build\xpcshell\tests\toolkit\components\passwordmgr\test\unit\test_storage_legacy_2.js | test failed (with xpcshell return code: 0), see following log:

Status: VERIFIED FIXED

(Core :: General, defect)

Description

[Makoto Kato [:m_kato]]

After landing bug 675553, this perma-orange occurs on Win64.  But this doesn't occurs if using VC10SP1.

Comment 1

[Makoto Kato [:m_kato]]

This depends on compiler.  This occurs when script uses boolean type.  When casting to bool, the value is converted to true except to 0.  We need cast to PRUint8 at first, then cast to bool.

Comment 2

[Makoto Kato [:m_kato]]

Attachment: fix

Comment 4

[alanjstr]

Since this broke up/down/tab in all dropdowns on x64, should the severity be increased?

Comment 5

[Anh Le]

How to apply the patch?

Comment 7

[Veritas]

I can confirm (as the author of bug 692102) that it does indeed kill all of the drop down tab/arrow ordering.  I just had only thus far noticed it on the location bar.

Comment 9

[Anh Le]

I have the same issue with form in the web page, such as I input my username in Gmail login

Comment 10

[Justin Wood (:Callek)]

(In reply to Makoto Kato from comment #2)
> Created attachment 563712 [details] [diff] [review] [diff] [details] [review]
> fix

Possibly sending this through try, would help Ben with his review ;-)

Comment 13

[Makoto Kato [:m_kato]]

https://hg.mozilla.org/mozilla-central/rev/8c82de08425d

Comment 14

[David Chalkley]

Is this fix included in a future Firefox nightly update OR do we need to apply the fix ourselves (and if so how?)?

Comment 15

[Kevin Brosnan [Ex-Mozilla]]

Verified fixed - Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:10.0a1) Gecko/20111006 Firefox/10.0a1