Closed
Bug 690849
Opened 13 years ago
Closed 13 years ago
Fix height of dialog buttons
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox9 verified, firefox10 verified)
VERIFIED
FIXED
Firefox 9
People
(Reporter: wesj, Assigned: sriram)
References
Details
(Whiteboard: [fixed in aurora])
Attachments
(1 file)
699 bytes,
patch
|
wesj
:
review+
mfinkle
:
review+
asa
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
The prefs pane patch changed the style of our buttons. I think it accidently made buttons on prompts/dialogs/etc slightly smaller. We should make them big again.
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → sriram
Assignee | ||
Comment 1•13 years ago
|
||
A padding was missing. This has been added.
Attachment #563814 -
Flags: review?(wjohnston)
Attachment #563814 -
Flags: review?(mark.finkle)
Updated•13 years ago
|
Attachment #563814 -
Flags: review?(mark.finkle) → review+
Reporter | ||
Updated•13 years ago
|
Attachment #563814 -
Flags: review?(wjohnston) → review+
Comment 2•13 years ago
|
||
Pushed to inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/6c540571b551 Aurora 9 is not currently affected, but we should request approval if we decide to land bug 682412 on Aurora.
Status: NEW → ASSIGNED
Target Milestone: --- → Firefox 10
Comment 3•13 years ago
|
||
(In reply to Matt Brubeck (:mbrubeck) from comment #2) > Pushed to inbound: > https://hg.mozilla.org/integration/mozilla-inbound/rev/6c540571b551 Code changes, no matter how trivial, shouldn't be DONTBUILD. If some test breaks (yes, unexpectedly!), the initial blame is going to be on the subsequent landing (me in this case).
Comment 4•13 years ago
|
||
(In reply to Dão Gottwald [:dao] from comment #3) > Code changes, no matter how trivial, shouldn't be DONTBUILD. If some test > breaks (yes, unexpectedly!), the initial blame is going to be on the > subsequent landing (me in this case). Okay, sure. I was thinking of this as NPOTB because it was in a file that's used only on an platform (Android 3.0) that we don't have automated test machines for. But I'll try to err on the side of more testing instead instead of less. (I'm also the person who has personally backed out most of the breakage on inbound in the past week, so I am of course sympathetic to anything that makes that process easier.)
Comment 5•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6c540571b551
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment 6•13 years ago
|
||
Comment on attachment 563814 [details] [diff] [review] Patch Simple cleanup fix
Attachment #563814 -
Flags: approval-mozilla-aurora?
Updated•13 years ago
|
Updated•13 years ago
|
Attachment #563814 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 7•13 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/69b3acb2a4d6
Whiteboard: [fixed in aurora]
Target Milestone: Firefox 10 → Firefox 9
Comment 8•13 years ago
|
||
Mozilla/5.0 (Android;Linux armv7l;rv:10.0a1)Gecko/20110929 Firefox/9.0a2 Fennec/9.0a2 Device: HTC Desire Z OS: Android 2.3 Verified on latest Aurora build, prompts/dialogs/buttons... seem ok, but how do we know exactly how big should the prompts/buttons be? How can we verify this?
Updated•13 years ago
|
Whiteboard: [fixed in aurora] → [fixed in aurora][qa?]
Comment 9•12 years ago
|
||
Marking bug as verified since there is no longer an issue with dialog buttons height. Mozilla/5.0 (Android;Linux armv7l;rv:10.0)Gecko/20111228 Firefox/10.0 Fennec/10.0 Device: Samsung Galaxy S2 OS: Android 2.3
Status: RESOLVED → VERIFIED
Whiteboard: [fixed in aurora][qa?] → [fixed in aurora]
You need to log in
before you can comment on or make changes to this bug.
Description
•