690973 - [tabletui] Opening a new tab in portrait mode does not open the awesomescreen

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Matt Brubeck (:mbrubeck)]

Attachment: patch

Steps to reproduce:
1. Open fennec in portrait mode on tablet
2. Tap the tabs button to open the menu
3. Press the "New tab" button in the menu

Expected results: New tab opens, urlbar is focused, and awesomescreen drop-down appears.

Actual results: New tab opens but urlbar is not focused and awesomescreen does not appear.

This is a problem from my patch in bug 688840.  hidePortraitMenu refers to an undefined variable "resizeHandler".  This moves resizeHandler back to its own method of TabsPopup, and calls bind from init to avoid the problem that bug 688840 was trying to fix.

Comment 1

[Wesley Johnston (:wesj)]

Comment on attachment 563902 [details] [diff] [review]
patch

Review of attachment 563902 [details] [diff] [review]:
-----------------------------------------------------------------

Please add some sort of comment explaining why we're doing:

this.resizeHandler = this.resizeHandler.bind(this);

and maybe some comments at the event listeners noting its already bound... Otherwise I'm sure I'll stare at it someday wondering what's going on.

Comment 2

[Matt Brubeck (:mbrubeck)]

Pushed with added comment: https://hg.mozilla.org/integration/mozilla-inbound/rev/a89bf0c36977

Comment 3

[Matt Brubeck (:mbrubeck)]

Comment on attachment 563902 [details] [diff] [review]
patch

Requesting approval for Aurora 9.  This is a fix for a regression in Firefox 9 that breaks the user experience of opening a new tab (in portrait mode, on tablets).  The fix is mobile-only and very localized.  It fixes an undefined variable access exception that happens every time the portrait tab menu is hidden.

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/mozilla-central/rev/a89bf0c36977

Comment 5

[Aaron Train [:aaronmt]]

Verified Fixed on Nightly
Mozilla/5.0 (Android; Linux armv7l; rv:10.0a1) Gecko/20111003 Firefox/10.0a1 Fennec/10.0a1

Comment 6

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4a81215700fb

Comment 7

[Camelia Urian]

Verified Fixed on Aurora
Mozilla/5.0 (Android; Linux armv7l; rv:9.0a2) Gecko/20111013 Firefox/9.0a2 Fennec/9.0a2

When pressing  "New Tab" button wew tab opens, urlbar is focused, and awesomescreen drop-down appears.

Comment 8

[Johnny Stenback (:jst)]

This landed on aurora for 9, not tracking.