690974 - Add strict equality inline paths for objects and strings

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: patch

This gives a modest speedup on earley-boyer.

Comment 1

[Brian Hackett [Laid off!]]

Comment on attachment 563903 [details] [diff] [review]
patch

Can you paste numbers for the earley-boyer speedup you're getting, or a microbenchmark before/after?

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

In the modified earley-boyer test case from bug 642001 comment 10, I get these numbers:

with patch: 3.074s
without patch: 3.434s

Comment 3

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/70433779ffa7

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/70433779ffa7

Comment 5

[Brendan Eich [:brendan]]

Comment on attachment 563903 [details] [diff] [review]
patch

>+            return jumpAndTrace(fast, target, &sj) ? Compile_Okay : Compile_Error;
>+        } else {

r=me to fix this else after return in moved code, any time.

/be