691012 - DOMTemplate needs chrome tests

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Joe Walker [:jwalker]]

These tests should be ported:
https://github.com/joewalker/domtemplate/blob/master/test/index.html

Comment 1

[Joe Walker [:jwalker]]

Attachment: upload 1

Rob back in bug 684958 comment 11, you asked for templater tests. Theses are they. One of the tests is commented out because it uncovered bug 692031. I'll be uploading a patch there to soon.

Comment 2

[Joe Walker [:jwalker]]

Pls ignore typos in comments. It's late. :)

Comment 3

[Joe Walker [:jwalker]]

Attachment: upload 2

Minor tweaks as a result of the changes in bug 692424.

We're deleting an HTML file that was added in bug 692424 - it's just an easy way of getting out of make wanting HTML files to copy. Call me lazy, I'm sure there is a better way, but this has the same effect and it works :)

Comment 4

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 566239 [details] [diff] [review]
upload 2

diff --git a/browser/devtools/shared/test/browser_templater_basic.html b/browser/devtools/shared/test/browser_templater_basic.html
new file mode 100644

+</html>
\ No newline at end of file

good! thanks for the tests! :)

Comment 5

[Joe Walker [:jwalker]]

Attachment: upload 3

Adds newline :)

Comment 6

[Joe Walker [:jwalker]]

Try log:
https://tbpl.mozilla.org/?tree=Try&rev=f2eedda104b1

Comment 7

[Rob Campbell [:rc] (:robcee)]

upload 3: https://hg.mozilla.org/integration/fx-team/rev/4322ee96f796

Comment 8

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/mozilla-central/rev/4322ee96f796