691253 - JavaScript strict warning: chrome://browser/content/browser.js, line 10581: reference to undefined property this._updateFeedTimeout

Status: RESOLVED FIXED

(Firefox Graveyard :: RSS Discovery and Preview, defect)

Description

[Richard Newman [:rnewman]]

// If this addition was for the current browser, update the UI. For
    // background browsers, we'll update on tab switch.
    if (browserForLink == gBrowser.selectedBrowser) {
      // Batch updates to avoid updating the UI for multiple onLinkAdded events
      // fired within 100ms of each other.
      clearTimeout(this._updateFeedTimeout);
      this._updateFeedTimeout = setTimeout(this.updateFeeds.bind(this), 100);
    }
  }
};


On current trunk.

Comment 1

[Tobias (:Tobbi) Markus]

Attachment: patch v1

Who's the right person to request review from?

Comment 2

[Marco Bonardo [:mak]]

Comment on attachment 578593 [details] [diff] [review]
patch v1

Review of attachment 578593 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you for the patch, I have one style comment to address, apart that looks fine.

::: browser/base/content/browser.js
@@ +7659,5 @@
>      if (browserForLink == gBrowser.selectedBrowser) {
>        // Batch updates to avoid updating the UI for multiple onLinkAdded events
>        // fired within 100ms of each other.
> +      if(this._updateFeedTimeout)
> +        clearTimeout(this._updateFeedTimeout);

Add a whitespace between if and the parenthesis

Comment 3

[Tobias (:Tobbi) Markus]

Attachment: v1.1

Fixing the style nit

Comment 4

[Richard Newman [:rnewman]]

Landed on inbound:

https://hg.mozilla.org/integration/mozilla-inbound/rev/9b6c9d4bd1ff

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/9b6c9d4bd1ff

Comment 6

[boguskyss]

Comment on attachment 578601 [details] [diff] [review]
v1.1

Review of attachment 578601 [details] [diff] [review]:
-----------------------------------------------------------------

I get this in FIREFOX 14.0.1-- HOW DO I STOP IT!!!!
A script on this page may be busy, or it may have stopped responding. You can stop the script now, or you can continue to see if the script will complete.

Script: chrome://browser/content/browser.js:8047

Comment 7

[Daniel "warmth" Delgado]

Still having this on Firefox 29.0a1, why?

"script: chrome://browser/content/browser.js:12322"

Comment 8

[kemsky]

The same problem on 45.7.0
i think the matter OSes

try to register the library:
Regsvr32 urlmon.dll