691712 - Add some pretty resizers to the Highlighter toolbar when the HTML tree panel is open

Status: VERIFIED FIXED

(DevTools :: General, defect)

Description

[Paul Rouget [:paul]]

We want to be able to resize the tree panel. The current situation (using the free space in the toolbar as a resizer) is blocking further developments in the toolbar (like the breadcrumbs).

Comment 1

[Paul Rouget [:paul]]

Attachment: Shorlander's proposal

Comment 2

[Paul Rouget [:paul]]

Attachment: patch v1

Rob, would that work for you?

Comment 3

[Paul Rouget [:paul]]

Attachment: screenshot patch v1

Comment 4

[Paul Rouget [:paul]]

Attachment: screenshot patch v1 - with active regions

Comment 6

[Paul Rouget [:paul]]

Attachment: patch v1.1

CSS tweaks.

Comment 7

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 564568 [details] [diff] [review]
patch v1.1

fantastique!

Comment 8

[Stephen Horlander [:shorlander]]

Attachment: Resize Grippy

Can we use this image instead? Or alter the gradient to match it?

Mockup: http://cl.ly/1D3A0D0y2a1z3r0U1P11

Comment 9

[Paul Rouget [:paul]]

Ok, I'll update the gradient

Comment 10

[Paul Rouget [:paul]]

Attachment: patch v1.2

prettier.

Comment 11

[Paul Rouget [:paul]]

Attachment: screenshot patch v1.2

Comment 12

[Paul Rouget [:paul]]

Oops, I think this is 2 pixels too small.

Comment 13

[Paul Rouget [:paul]]

Attachment: patch v1.3

Comment 14

[Paul Rouget [:paul]]

Attachment: screenshot patch v1.3

Comment 15

[Paul Rouget [:paul]]

Attachment: patch v1.4

One pixel row was missing

Comment 16

[Rob Campbell [:rc] (:robcee)]

Review ping! We have some patches reliant on this.

Comment 17

[Paul Rouget [:paul]]

Attachment: patch v1.5

rebased

Comment 18

[Dão Gottwald [:dao]]

Comment on attachment 568630 [details] [diff] [review]
patch v1.5

>--- a/browser/themes/pinstripe/browser/browser.css
>+++ b/browser/themes/pinstripe/browser/browser.css

> #inspector-toolbar {
>   -moz-appearance: none;
>-  padding: 4px 3px;
>+  padding: 0px 3px 4px 3px;

nit: 0 instead of 0px

>+#inspector-end-resizer {
>+  width: 12px; height: 8px;

new line after ;

>+  background-image: -moz-linear-gradient(top,black 1px,rgba(255, 255, 255, 0.2) 1px) !important;

Why do you need !important here?

nit: add a space after each comma, *except* within color functions:
-moz-linear-gradient(top, black 1px, rgba(255,255,255,0.2) 1px)

>@@ -2670,8 +2688,9 @@ panel[dimmed="true"] {
> #highlighter-nodeinfobar-container[position="top"] > #highlighter-nodeinfobar,
> #highlighter-nodeinfobar-container[position="overlap"] > #highlighter-nodeinfobar {
>   box-shadow: 0 1px 0 hsla(0, 0%, 100%, .1) inset;
> }
> 
> #highlighter-nodeinfobar-container[hide-arrow] > #highlighter-nodeinfobar {
>   margin: 7px 0;
> }
>+

bogus change

Comment 19

[Rob Campbell [:rc] (:robcee)]

so, r+ with those changes, Dao?

Comment 20

[Dão Gottwald [:dao]]

Comment on attachment 568630 [details] [diff] [review]
patch v1.5

I'd prefer seeing a new patch, as I've seen people mess up trivial changes, forget some of our three themes, etc.

Also waiting for a response regarding !important.

By the way, write "padding: 0 3px 4px;" instead of "padding: 0 3px 4px 3px;". This makes it more obvious that the padding is symmetrical (so RTL won't be an issue).

Comment 21

[Paul Rouget [:paul]]

Attachment: patch v1.6

Addressed Dao's comments. !important wasn't useful. I was too aggressive with the background:none!important.

Comment 22

[Dão Gottwald [:dao]]

Comment on attachment 569713 [details] [diff] [review]
patch v1.6

>+          <toolbarseparator />

nit: remove the space before />

>+    let resizerTop = 

trailing space

>+    let resizerEnd = 

ditto

>+#inspector-end-resizer {

>+  border-width: 1px 1px 0 1px;

border-width: 1px 1px 0;
(affects all themes)

>+  margin: 7px 7px 8px 7px;

margin: 7px 7px 8px;
(affects all themes)

Comment 23

[Paul Rouget [:paul]]

Attachment: patch v1.7

Thanks for the r+ Dao.

Comment 24

[Dave Camp (:dcamp)]

https://hg.mozilla.org/integration/fx-team/rev/ca0e85e9fe89

Comment 25

[:Margaret Leibovic]

https://hg.mozilla.org/mozilla-central/rev/ca0e85e9fe89

Comment 26

[Ioan C.]

Mozilla/5.0 (Windows NT 5.1; rv:10.0a2) Gecko/20111123 Firefox/10.0a2
Verified fixed. http://screencast.com/t/0IGuh6gZpy1s