Closed Bug 691845 Opened 13 years ago Closed 13 years ago

importxml.pl complains if an open bug has the resolution field set to ''

Categories

(Bugzilla :: Bug Import/Export & Moving, defect)

4.0.2
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 4.0

People

(Reporter: LpSolit, Assigned: LpSolit)

References

Details

(Keywords: regression)

Attachments

(1 file)

With bug 653263, the resolution field is now always present in the XML file, even for open bugs, and importxml.pl now complains that we tried to set a resolution for this bug. The reason is that importxml.pl checks if the resolution field is defined, not set to something. It should treat an empty resolution the same way as a missing resolution.
Attached patch patch, v1Splinter Review
Attachment #565012 - Flags: review?(dkl)
Comment on attachment 565012 [details] [diff] [review]
patch, v1

Review of attachment 565012 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good and works as expected. r=dkl
Attachment #565012 - Flags: review?(dkl) → review+
Flags: approval4.2+
Flags: approval4.0+
Flags: approval+
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified importxml.pl
Committed revision 7974.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.2/
modified importxml.pl
Committed revision 7940.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.0/
modified importxml.pl
Committed revision 7651.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: