691978 - CssLogic doesn't discern between inherited and not-inherited properties.

Status: RESOLVED FIXED

(DevTools :: General, defect, P2)

Description

[Dave Camp (:dcamp)]

Attachment: test case

CssLogic considers a matches for parent elements for both inherited properties (such as text-align) and not-inherited properties (such as border)

Load the attached test case and look at #div2 in the style inspector.  For border-bottom-width it shows the proper computed style (0px), but shows a matched 1px selector for #div1.

Comment 1

[Mihai Sucan [:msucan]]

Thanks for the bug report Dave!

If I recall correctly, this was a known bug at the time when we worked on CssLogic (me and Joe). Didn't we have an open bug? To make a list of props that are inherited (or something), to not consider matches those parent elements which have props that do not inherit.

Comment 2

[Dave Camp (:dcamp)]

Attachment: WIP

Here's a fix, will write a test case tomorrow morning.

Comment 3

[Mihai Sucan [:msucan]]

Comment on attachment 572395 [details] [diff] [review]
WIP

Review of attachment 572395 [details] [diff] [review]:
-----------------------------------------------------------------

Patch looks good!

Comment 4

[Dave Camp (:dcamp)]

Attachment: with tests

Comment 5

[Mihai Sucan [:msucan]]

Comment on attachment 572495 [details] [diff] [review]
with tests

Review of attachment 572495 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good!

::: browser/devtools/styleinspector/test/browser/browser_csslogic_inherited.js
@@ +12,5 @@
> +{
> +  doc.body.innerHTML = '<div style="margin-left:10px; font-size: 5px"><div id="innerdiv">Inner div</div></div>';
> +  doc.title = "Style Inspector Inheritance Test";
> +
> +  cssLogic = new CssLogic();

let cssLogic = ...

Comment 6

[Dave Camp (:dcamp)]

https://hg.mozilla.org/integration/fx-team/rev/110ccc3eb353

Comment 7

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/mozilla-central/rev/110ccc3eb353