Closed
Bug 692269
Opened 13 years ago
Closed 12 years ago
Remove jsstr.h and vm/String.h from INSTALLED_HEADERS
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla13
People
(Reporter: billm, Assigned: luke)
References
Details
Attachments
(1 file)
17.29 KB,
patch
|
billm
:
review+
|
Details | Diff | Splinter Review |
Any takers?
Assignee | ||
Comment 1•13 years ago
|
||
I can. Does this depend on jscntxt.h removal?
Reporter | ||
Comment 2•13 years ago
|
||
(In reply to Luke Wagner [:luke] from comment #1) > I can. Does this depend on jscntxt.h removal? I don't think so.
Assignee | ||
Comment 3•12 years ago
|
||
The patch also kills some random installed headers that were easy: jsautokw.h, jsclone.h, jsopcode.tbl, jsopcode.h, jsstdint.h.
Assignee | ||
Comment 4•12 years ago
|
||
Green on try
Reporter | ||
Comment 5•12 years ago
|
||
Comment on attachment 592560 [details] [diff] [review] un-install vm/String.h and some others Review of attachment 592560 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/jsatominlines.h @@ +198,5 @@ > } > > +inline > +AtomHasher::Lookup::Lookup(const JSAtom *atom) > + : chars(atom->chars()), length(atom->length()), atom(atom) I think we usually have two spaces before the : here.
Attachment #592560 -
Flags: review?(wmccloskey) → review+
Assignee | ||
Comment 6•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/f5ff7098d6a4
Target Milestone: --- → mozilla13
Comment 7•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f5ff7098d6a4
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•