Closed
Bug 692305
Opened 13 years ago
Closed 13 years ago
Append PID to cycle collector graph dumps
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla10
People
(Reporter: azakai, Assigned: azakai)
Details
(Whiteboard: [MemShrink][Inbound])
Attachments
(1 file, 1 obsolete file)
|
1.15 KB,
patch
|
dougt
:
review+
|
Details | Diff | Splinter Review |
In Fennec and multiprocess Firefox, dumping CC graphs is at risk of the two processes overwriting each other. Appending the PID would solve that. Attached is a patch that works in Linux. I am not sure what to do in other OSes.
|
||
Updated•13 years ago
|
Component: IPC → XPCOM
QA Contact: ipc → xpcom
|
|
||
Updated•13 years ago
|
Whiteboard: [MemShrink]
#include "base/process_util.h"
using namespace base;
snprintf("...%d...", GetCurrentProcId());
|
Assignee | |
Comment 2•13 years ago
|
||
Thanks cjones!
Attachment #565045 -
Attachment is obsolete: true
Attachment #565060 -
Flags: review?(doug.turner)
|
||
Updated•13 years ago
|
Attachment #565060 -
Flags: review?(doug.turner) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/3b520aebb3fa
Whiteboard: [MemShrink] → [MemShrink][Inbound]
|
||
Comment 4•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/3b520aebb3fa
Assignee: nobody → azakai
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in
before you can comment on or make changes to this bug.
Description
•