692434 - == instead of = when trying to assign a new encoding name in XHR

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Henri Sivonen (:hsivonen)]

Bug 687087 introduced this:
if (mResponseCharset != document->GetDocumentCharacterSet()) {
  mResponseCharset == document->GetDocumentCharacterSet();

Should be
if (mResponseCharset != document->GetDocumentCharacterSet()) {
  mResponseCharset = document->GetDocumentCharacterSet();

(== vs. =)

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Need to fix this asap, since Bug 687087 is in Aurora.

Comment 2

[Henri Sivonen (:hsivonen)]

Attachment: Use = instead of ==, with a test

Taking. I need this fixed for bug 651072.

Comment 3

[Henri Sivonen (:hsivonen)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6bae7a490cb0

Comment 4

[Henri Sivonen (:hsivonen)]

Comment on attachment 565480 [details] [diff] [review]
Use = instead of ==, with a test

Requesting approval for Aurora. The code that has the extra equals sign was recently introduced but has made it to Aurora already. Letting it get to release could at least in theory break cases where XHR is used for reading non-UTF-8 XML as text.

Comment 5

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/6bae7a490cb0

Comment 6

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

I wonder if we can make the compiler error here.  On Windows we're already erroring for "lvalue == rvalue;" for primitive types.

Comment 7

[Henri Sivonen (:hsivonen)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/939e5e3e2015

Comment 8

[Mihaela Velimiroviciu (:mihaelav)]

[qa-] because of code related issue.