692658 - add acknowledgement phase to auth workflow

Status: RESOLVED FIXED

(Cloud Services :: Server: Core, enhancement)

Description

[Ryan Kelly [:rfkelly]]

Attachment: patch adding an "acknowledge" phase to the auth workflow

Current server-core allows the authentication class to check credentials on the request, but provides no means to set headers on outgoing responses.

Attached patch adds an "acknowledge" phase where the auth class can tweak the outgoing response.  It also expands the baseapp tests for more comprehensive testing of the auth class, e.g. testing that it correctly passes through HTTPNotFound errors raised in the controller.

Some examples where such acknowledgement can be useful include setting a signed cookie to remember the login, or sending an updated digest-auth nonce in the Authentication-Info header.

(this is mostly an enabling patch for the next step - implementing a "WhoAuthenticator" class so existing apps can use the upcoming repoze.who auth plugins)

Comment 1

[Rob Miller [:rmiller]]

Comment on attachment 565399 [details] [diff] [review]
patch adding an "acknowledge" phase to the auth workflow

Review of attachment 565399 [details] [diff] [review]:
-----------------------------------------------------------------

awesome.  :)

Comment 2

[Ryan Kelly [:rfkelly]]

Committed in http://hg.mozilla.org/services/server-core/rev/186175cd2066