Closed
Bug 692927
Opened 13 years ago
Closed 13 years ago
Show compatibility error if an add-on uses geo.wifi.uri or geo.wifi.protocol
Categories
(addons.mozilla.org Graveyard :: Compatibility Tools, defect, P2)
addons.mozilla.org Graveyard
Compatibility Tools
Tracking
(Not tracked)
RESOLVED
FIXED
6.2.7
People
(Reporter: jorgev, Assigned: ashort)
References
Details
(Whiteboard: [fx9])
As explained in bug 689252, the preferences "geo.wifi.uri" and "geo.wifi.protocol" will cease to have any meaning in Firefox. We need to flag all instances of these preferences and show an error. This is a compatibility error, so the add-on should not be upgraded in this case. Message: The "geo.wifi.*" preferences are no longer in use. See <LINK> for more information. Link: https://bugzilla.mozilla.org/show_bug.cgi?id=689252 Affected add-on: https://addons.mozilla.org/en-US/firefox/addon/geolocater/
Assignee | ||
Comment 1•13 years ago
|
||
Since these are still readable, should this be an error instead of a warning? Not sure the validator can tell if an addon deals with the absence of these properties correctly.
Reporter | ||
Comment 2•13 years ago
|
||
It is still an error because trying to access the preference without setting it first will throw an exception.
Assignee | ||
Comment 3•13 years ago
|
||
Fixed. https://github.com/mozilla/amo-validator/commit/b0379f295723c392a0cd26bdde529d743a978f39
Assignee | ||
Comment 4•13 years ago
|
||
Fixed. https://github.com/mozilla/amo-validator/commit/b0379f295723c392a0cd26bdde529d743a978f39
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•8 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•